Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add configuration for stable environment #442

Closed
wants to merge 1 commit into from

Conversation

ds-lcapellino
Copy link
Contributor

@ds-lcapellino ds-lcapellino commented Oct 7, 2024

Description

This PR will introduce environment specific configuration for the 24.08 release to run on the catena-x stable environment.

Issue

relates to #408

Checklist

Please delete options that are not relevant.

  • I have performed a self-review of my changes
  • I have successfully tested my changes
  • I have added comments in the default values.yaml file with helm-docs syntax ('# -- ') if relevant for installation
  • I have commented my changes, particularly in hard-to-understand areas

@ds-lcapellino ds-lcapellino changed the title feature: Add configuration for stable environment feat: Add configuration for stable environment Oct 7, 2024
Copy link
Contributor

@evegufy evegufy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please fix secret path everywhere

environments/helm-values/values-stable.yaml Outdated Show resolved Hide resolved
@ds-lcapellino ds-lcapellino force-pushed the feature/add-stable-environment-config branch from b028744 to 1b5bc46 Compare October 7, 2024 13:11
@evegufy
Copy link
Contributor

evegufy commented Oct 16, 2024

@ds-lcapellino as discussed, I'm closing this PR as it doesn't make sense to merge it main because there we're are already ahead of the v2.1.0, the branch can still be used for installing v2.1.0

@evegufy evegufy closed this Oct 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: USER READY
Development

Successfully merging this pull request may close these issues.

2 participants