Skip to content

Commit

Permalink
feat: add imagePullSecrets (#52)
Browse files Browse the repository at this point in the history
  • Loading branch information
mgarciaLKS authored Sep 23, 2024
1 parent 1fb4e25 commit 7c75f90
Show file tree
Hide file tree
Showing 3 changed files with 10 additions and 0 deletions.
4 changes: 4 additions & 0 deletions charts/ssi-asr/templates/deployment-registry-service.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -36,6 +36,10 @@ spec:
labels:
{{- include "asr.selectorLabels" . | nindent 8 }}
spec:

Check warning on line 38 in charts/ssi-asr/templates/deployment-registry-service.yaml

View workflow job for this annotation

GitHub Actions / Analyze

[MEDIUM] Service Account Token Automount Not Disabled

Service Account Tokens are automatically mounted even if not necessary

Check warning on line 38 in charts/ssi-asr/templates/deployment-registry-service.yaml

View workflow job for this annotation

GitHub Actions / Analyze

[MEDIUM] Service Account Token Automount Not Disabled

Service Account Tokens are automatically mounted even if not necessary

Check warning on line 38 in charts/ssi-asr/templates/deployment-registry-service.yaml

View workflow job for this annotation

GitHub Actions / Analyze

[MEDIUM] Service Account Token Automount Not Disabled

Service Account Tokens are automatically mounted even if not necessary
{{- with .Values.service.image.pullSecrets }}
imagePullSecrets:
{{- toYaml . | nindent 8 }}
{{- end }}
containers:

Check warning on line 43 in charts/ssi-asr/templates/deployment-registry-service.yaml

View workflow job for this annotation

GitHub Actions / Analyze

[MEDIUM] Container Running With Low UID

Check if containers are running with low UID, which might cause conflicts with the host's user table.

Check warning on line 43 in charts/ssi-asr/templates/deployment-registry-service.yaml

View workflow job for this annotation

GitHub Actions / Analyze

[MEDIUM] Seccomp Profile Is Not Configured

Containers should be configured with a secure Seccomp profile to restrict potentially dangerous syscalls

Check warning on line 43 in charts/ssi-asr/templates/deployment-registry-service.yaml

View workflow job for this annotation

GitHub Actions / Analyze

[LOW] Image Pull Policy Of The Container Is Not Set To Always

Image Pull Policy of the container must be defined and set to Always

Check warning on line 43 in charts/ssi-asr/templates/deployment-registry-service.yaml

View workflow job for this annotation

GitHub Actions / Analyze

[LOW] Image Without Digest

Images should be specified together with their digests to ensure integrity

Check warning on line 43 in charts/ssi-asr/templates/deployment-registry-service.yaml

View workflow job for this annotation

GitHub Actions / Analyze

[MEDIUM] Container Running With Low UID

Check if containers are running with low UID, which might cause conflicts with the host's user table.

Check warning on line 43 in charts/ssi-asr/templates/deployment-registry-service.yaml

View workflow job for this annotation

GitHub Actions / Analyze

[MEDIUM] Seccomp Profile Is Not Configured

Containers should be configured with a secure Seccomp profile to restrict potentially dangerous syscalls

Check warning on line 43 in charts/ssi-asr/templates/deployment-registry-service.yaml

View workflow job for this annotation

GitHub Actions / Analyze

[LOW] Image Pull Policy Of The Container Is Not Set To Always

Image Pull Policy of the container must be defined and set to Always

Check warning on line 43 in charts/ssi-asr/templates/deployment-registry-service.yaml

View workflow job for this annotation

GitHub Actions / Analyze

[LOW] Image Without Digest

Images should be specified together with their digests to ensure integrity

Check warning on line 43 in charts/ssi-asr/templates/deployment-registry-service.yaml

View workflow job for this annotation

GitHub Actions / Analyze

[MEDIUM] Container Running With Low UID

Check if containers are running with low UID, which might cause conflicts with the host's user table.

Check warning on line 43 in charts/ssi-asr/templates/deployment-registry-service.yaml

View workflow job for this annotation

GitHub Actions / Analyze

[MEDIUM] Seccomp Profile Is Not Configured

Containers should be configured with a secure Seccomp profile to restrict potentially dangerous syscalls

Check warning on line 43 in charts/ssi-asr/templates/deployment-registry-service.yaml

View workflow job for this annotation

GitHub Actions / Analyze

[LOW] Image Pull Policy Of The Container Is Not Set To Always

Image Pull Policy of the container must be defined and set to Always

Check warning on line 43 in charts/ssi-asr/templates/deployment-registry-service.yaml

View workflow job for this annotation

GitHub Actions / Analyze

[LOW] Image Without Digest

Images should be specified together with their digests to ensure integrity
- name: {{ include "asr.fullname" . }}
securityContext:
Expand Down
4 changes: 4 additions & 0 deletions charts/ssi-asr/templates/job-registry-migrations.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -31,6 +31,10 @@ spec:
name: {{ include "asr.fullname" . }}-{{ .Values.migrations.name }}
spec:
restartPolicy: Never
{{- with .Values.migrations.image.pullSecrets }}
imagePullSecrets:
{{- toYaml . | nindent 8 }}
{{- end }}
containers:
- name: {{ include "asr.fullname" . }}-{{ .Values.migrations.name }}
securityContext:
Expand Down
2 changes: 2 additions & 0 deletions charts/ssi-asr/values.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -21,6 +21,7 @@ service:
image:
name: "docker.io/tractusx/ssi-authority-schema-registry-service"
tag: ""
pullSecrets: []
imagePullPolicy: "IfNotPresent"
# -- We recommend to review the default resource limits as this should a conscious choice.
resources:
Expand Down Expand Up @@ -50,6 +51,7 @@ migrations:
image:
name: "docker.io/tractusx/ssi-authority-schema-registry-migrations"
tag: ""
pullSecrets: []
imagePullPolicy: "IfNotPresent"
# -- We recommend to review the default resource limits as this should a conscious choice.
resources:
Expand Down

0 comments on commit 7c75f90

Please sign in to comment.