Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add imagePullSecrets #52

Merged
merged 3 commits into from
Sep 23, 2024
Merged

Conversation

mgarciaLKS
Copy link
Contributor

Description

The imagePullSecrets field allows you to specify secrets needed to pull Docker images from private repositories.
Request by @evegufy

Why

In many organizations, container images are stored in private registries rather than public ones for security and compliance reasons. To pull these images, Kubernetes needs credentials, which are provided via imagePullSecrets. This code dynamically includes the necessary secrets for pulling images, based on the configuration provided in the Helm chart's values file.

Checklist

Please delete options that are not relevant.

  • I have followed the contributing guidelines
  • I have performed IP checks for added or updated 3rd party libraries
  • I have created and linked IP issues or requested their creation by a committer
  • I have performed a self-review of my own code
  • I have successfully tested my changes locally

@MaximilianHauer MaximilianHauer added this to the Release 24.12 milestone Sep 13, 2024
@Phil91 Phil91 requested a review from evegufy September 17, 2024 13:19
Copy link
Contributor

@evegufy evegufy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @mgarciaLKS thank you for your contribution! Could you please enable the imagePullSecrets also for the migrations job?

@evegufy
Copy link
Contributor

evegufy commented Sep 23, 2024

Thank you @mgarciaLKS

@evegufy evegufy merged commit 7c75f90 into eclipse-tractusx:main Sep 23, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: USER READY
Development

Successfully merging this pull request may close these issues.

3 participants