Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(config): make wallet application and paths configurable #230

Merged
merged 3 commits into from
Aug 14, 2024
Merged

feat(config): make wallet application and paths configurable #230

merged 3 commits into from
Aug 14, 2024

Conversation

Phil91
Copy link
Member

@Phil91 Phil91 commented Aug 2, 2024

Description

  • make application of the wallet configurable
  • make wallet paths configurable

Why

To be able to support multiple wallets

Issue

Refs: #226

Checklist

  • I have followed the contributing guidelines
  • I have performed IP checks for added or updated 3rd party libraries
  • I have created and linked IP issues or requested their creation by a committer
  • I have performed a self-review of my own code
  • I have successfully tested my changes locally
  • I have added tests that prove my changes work
  • I have checked that new and existing tests pass locally with my changes
  • I have commented my code, particularly in hard-to-understand areas
  • I have added copyright and license headers, footers (for .md files) or files (for images)

evegufy
evegufy requested changes Aug 13, 2024
View reviewed changes
charts/ssi-credential-issuer/values.yaml Outdated Show resolved Hide resolved
charts/ssi-credential-issuer/values.yaml Outdated Show resolved Hide resolved
charts/ssi-credential-issuer/values.yaml Outdated Show resolved Hide resolved
charts/ssi-credential-issuer/values.yaml Outdated Show resolved Hide resolved
charts/ssi-credential-issuer/values.yaml Outdated Show resolved Hide resolved
charts/ssi-credential-issuer/values.yaml Outdated Show resolved Hide resolved
charts/ssi-credential-issuer/values.yaml Outdated Show resolved Hide resolved
src/externalservices/Wallet.Service/DependencyInjection/WalletSettings.cs Outdated Show resolved Hide resolved
src/externalservices/Wallet.Service/DependencyInjection/WalletSettings.cs Outdated Show resolved Hide resolved
@Phil91 Phil91 requested a review from evegufy August 14, 2024 08:23
@Phil91 @evegufy
chore: adjust signCredentialPath
f138400 
Refs: #226

Co-authored-by: Evelyn Gurschler <evelyn.gurschler@bmw.de>
@Phil91 Phil91 requested a review from evegufy August 14, 2024 15:10
@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Aug 14, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
100.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

@evegufy evegufy added this to the Release 24.12 milestone Aug 14, 2024
@Phil91 Phil91 merged commit 7232f27 into main Aug 14, 2024
11 checks passed
@Phil91 Phil91 deleted the feature/226-config branch August 14, 2024 18:03
@github-actions github-actions bot mentioned this pull request Sep 23, 2024
Merged
This was referenced Oct 10, 2024
Closed
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@evegufy evegufy evegufy approved these changes

@ntruchsess ntruchsess Awaiting requested review from ntruchsess

Assignees
No one assigned
Labels
None yet
Projects
Portal
Status: USER READY
Milestone
Release 24.12
Development

Successfully merging this pull request may close these issues.
2 participants
@Phil91 @evegufy