Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(ssi): merge create and sign credential into one #235

Merged
merged 1 commit into from
Sep 12, 2024

Conversation

Phil91
Copy link
Member

@Phil91 Phil91 commented Aug 16, 2024

Description

Merge the create and the sign credential step into one step

Why

Instead of creating and signing the credential in separate steps its easier and more efficient to create and sign them in one single step.

Issue

Refs: #232

Checklist

  • I have followed the contributing guidelines
  • I have performed IP checks for added or updated 3rd party libraries
  • I have created and linked IP issues or requested their creation by a committer
  • I have performed a self-review of my own code
  • I have successfully tested my changes locally
  • I have added tests that prove my changes work
  • I have checked that new and existing tests pass locally with my changes
  • I have commented my code, particularly in hard-to-understand areas
  • I have added copyright and license headers, footers (for .md files) or files (for images)

@Phil91 Phil91 requested review from evegufy and ntruchsess and removed request for evegufy August 16, 2024 09:24
Copy link

sonarcloud bot commented Aug 16, 2024

@Phil91 Phil91 added this to the Release 24.12 milestone Sep 5, 2024
Copy link
Contributor

@evegufy evegufy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Phil91 Phil91 merged commit 510de92 into main Sep 12, 2024
11 checks passed
@Phil91 Phil91 deleted the feature/232-create-sign branch September 12, 2024 09:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: USER READY
Development

Successfully merging this pull request may close these issues.

2 participants