Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(testdata): enable seeding via configMap, remove consortia files #241

Merged
merged 12 commits into from
Sep 27, 2024

Conversation

Phil91
Copy link
Member

@Phil91 Phil91 commented Aug 23, 2024

Description

remove seeding files from consortia and enable the option to seed testdata via configMaps instead

Why

the ending consortia isn't really matching anymore, since the provided data are just test data
and to keep test data separated from other seeding data

Issue

Refs: #205, #207

Checklist

  • I have followed the contributing guidelines
  • I have performed IP checks for added or updated 3rd party libraries
  • I have created and linked IP issues or requested their creation by a committer
  • I have performed a self-review of my own code
  • I have successfully tested my changes locally
  • I have added tests that prove my changes work
  • I have checked that new and existing tests pass locally with my changes
  • I have commented my code, particularly in hard-to-understand areas
  • I have added copyright and license headers, footers (for .md files) or files (for images)

@Phil91 Phil91 added this to the Release 24.12 milestone Aug 23, 2024
Copy link
Contributor

@evegufy evegufy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Related to the comment in the portal-backend eclipse-tractusx/portal-backend#957 (review)
I'd find it more sustainable to remove the files or better even enable a configmap for them: #207

@Phil91
Copy link
Member Author

Phil91 commented Sep 13, 2024

Related to the comment in the portal-backend eclipse-tractusx/portal-backend#957 (review) I'd find it more sustainable to remove the files or better even enable a configmap for them: #207

@evegufy adjusted to configmaps and added those for the test data

@Phil91 Phil91 force-pushed the feature/205-seeding branch 2 times, most recently from dead95f to 09d3e27 Compare September 13, 2024 08:20
@Phil91 Phil91 requested a review from evegufy September 13, 2024 08:21
Copy link
Contributor

@evegufy evegufy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

environments/argocd-app-templates/appsetup-int.yaml Outdated Show resolved Hide resolved
Copy link
Contributor

@evegufy evegufy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

could you please update the pr title and description and also mention #207

charts/ssi-credential-issuer/values.yaml Outdated Show resolved Hide resolved
charts/ssi-credential-issuer/values.yaml Outdated Show resolved Hide resolved
Copy link
Contributor

@evegufy evegufy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Phil91 Phil91 requested a review from evegufy September 26, 2024 06:34
charts/ssi-credential-issuer/values.yaml Outdated Show resolved Hide resolved
charts/ssi-credential-issuer/values.yaml Outdated Show resolved Hide resolved
@evegufy evegufy changed the title feat(seeding): adjust seeding from consortia to test feat(testdata): enable seeding via configMap, remove consortia files Sep 26, 2024
@evegufy evegufy linked an issue Sep 26, 2024 that may be closed by this pull request
@Phil91 Phil91 requested a review from evegufy September 27, 2024 06:17
Copy link
Contributor

@evegufy evegufy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

still needed to do some changes, it's tested successfully now

Copy link

sonarcloud bot commented Sep 27, 2024

@Phil91 Phil91 merged commit e3c92d3 into main Sep 27, 2024
11 checks passed
@Phil91 Phil91 deleted the feature/205-seeding branch September 27, 2024 15:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: USER READY
Development

Successfully merging this pull request may close these issues.

sig#779 - Enable configMap to seed test data
2 participants