Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: skip credential import if holder equals issuer #275

Merged
merged 1 commit into from
Oct 15, 2024

Conversation

Phil91
Copy link
Member

@Phil91 Phil91 commented Oct 14, 2024

Description

  • check if the holder equals the issuer, if so skip the import credential for holder step

Why

Currently the process step fails because the credential is already in the wallet

Issue

Refs: #250

Checklist

  • I have followed the contributing guidelines
  • I have performed IP checks for added or updated 3rd party libraries
  • I have created and linked IP issues or requested their creation by a committer
  • I have performed a self-review of my own code
  • I have successfully tested my changes locally
  • I have added tests that prove my changes work
  • I have checked that new and existing tests pass locally with my changes
  • I have commented my code, particularly in hard-to-understand areas
  • I have added copyright and license headers, footers (for .md files) or files (for images)

* check if the holder equals the issuer, if so skip the import credential for holder step

Refs: #250
@Phil91 Phil91 added this to the Release 24.12 milestone Oct 14, 2024
Copy link

sonarcloud bot commented Oct 14, 2024

@evegufy evegufy changed the title feat: check holder equals issuer feat: skip credential import if holder equals issuer Oct 14, 2024
@Phil91 Phil91 merged commit fd43a27 into main Oct 15, 2024
11 checks passed
@Phil91 Phil91 deleted the feature/250-issuer branch October 15, 2024 06:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: USER READY
Development

Successfully merging this pull request may close these issues.

2 participants