Skip to content

Commit

Permalink
Merge pull request #1060 from catenax-ng/chore/578-consistent-null-va…
Browse files Browse the repository at this point in the history
…lues

chore(concept): #578 integrate feedback
  • Loading branch information
ds-crehm authored Mar 14, 2024
2 parents af0bb80 + 1de48fe commit 7f5a2da
Show file tree
Hide file tree
Showing 4 changed files with 9 additions and 10 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -29,11 +29,11 @@ These should be consistent throughout Trace-X.

# Requirements
- Whenever a string value is saved or updated in the database and during data consumption from IRS:
- [ ] Leading and trailing whitespace characters are trimmed.
- [ ] Empty strings ("") are all converted to null.
- [ ] Null values are shown *empty* in the frontend.
- [ ] When sorting columns, empty values are shown all the way on the bottom regardless of the sort order.
- [ ] Empty values can be filtered and searched for. They are shown as "(Blank)" (de: "(Leer)") when filtering for them and can be searched by inputting the same term.
- [ ] Leading and trailing whitespace characters are trimmed.
- [ ] Empty strings ("") are all converted to null.
- [ ] Null values are shown as a dash "-" in the frontend.
- [ ] When sorting columns, null values are treated the default way of the database. (Shown at the end for ASC - shown at the beginning for DESC)
- [ ] Null values can be filtered for. They are shown as "-" when filtering for them. This option is always shown at the top of the filter/search box regardless of what the user is searching for.
- [ ] Leading and trailing whitespace characters don't count as mandatory values during user input.

# Out of scope
Expand All @@ -47,13 +47,12 @@ Whenever a string is saved or updated in the database and during data consumptio
3. Save/update value in database

### Frontend
Null values should be shown in the frontend as empty:
Null values should be shown in the frontend as a dash:

![null-value-display-empty.png](null-value-display-empty.png)
![null-value-display.png](null-value-display.png)

When sorting the values, empty ones should be always shown at the bottom regardless of the sort order.
Filtering and searching for empty values must be possible. In the filter box (Blank) (de: (Leer)) should be shown at the bottom.
To search for it, the user must type in the term "(Blank)" (de: (Leer)).
When sorting the values, null must be treated the default way of the database. When sorted ascending, they are at the end. When sorted descending, they are at the beginning.
Filtering for empty values must be possible. In the filter box "-" should always be shown at the top regardless of what the user is searching for.

![null-value-filter.png](null-value-filter.png)

Expand Down
Binary file not shown.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file modified docs/concept/#578-consistent-null-values/null-value-filter.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.

0 comments on commit 7f5a2da

Please sign in to comment.