feature: #639 remove PolicyCheckerService.isValid() check

eclipse-tractusx · Jun 18, 2024 · 81d839a · 81d839a
1 parent e1eb275
commit 81d839a
Show file tree

Hide file tree

Showing 2 changed files with 0 additions and 10 deletions.
diff --git a/...clipse/tractusx/traceability/notification/domain/base/service/NotificationsEDCFacade.java b/...clipse/tractusx/traceability/notification/domain/base/service/NotificationsEDCFacade.java
@@ -154,14 +154,6 @@ private CatalogItem getCatalogItem(final NotificationMessage notification, final
                                             .build())
                                     .build()
                     ).stream()
-                    .filter(catalogItem -> {
-                        log.info("-- catalog item check --");
-                        log.info("Item {}: {}", catalogItem.getItemId(), catalogItem);
-                        boolean isValid = policyCheckerService.isValid(catalogItem.getPolicy(), notification.getSendTo()
-                        );
-                        log.info("IsValid : {}", isValid);
-                        return isValid;
-                    })
                     .findFirst()
                     .orElseThrow();
         } catch (Exception e) {

diff --git a/...eclipse/tractusx/traceability/infrastructure/edc/blackbox/NotificationsEDCFacadeTest.java b/...eclipse/tractusx/traceability/infrastructure/edc/blackbox/NotificationsEDCFacadeTest.java
@@ -82,7 +82,6 @@ void givenCorrectInvestigationMessageButSendRequestThrowsException_whenStartEdcT
         final String idsPath = "/api/v1/dsp";
         when(edcProperties.getIdsPath()).thenReturn(idsPath);
         when(edcCatalogFacade.fetchCatalogItems(any())).thenReturn(List.of(catalogItem));
-        when(policyCheckerService.isValid(null, null)).thenReturn(true);
         when(contractNegotiationService.negotiate(receiverEdcUrl + idsPath, catalogItem, null, null))
                 .thenReturn(NegotiationResponse.builder().contractAgreementId(agreementId).build());
         when(endpointDataReference.getEndpoint()).thenReturn("endpoint");
@@ -111,7 +110,6 @@ void givenCorrectInvestigationMessageButNegotiateContractAgreementHasNoCatalogIt
         final String idsPath = "/api/v1/dsp";
         when(edcProperties.getIdsPath()).thenReturn(idsPath);
         when(edcCatalogFacade.fetchCatalogItems(any())).thenReturn(List.of(catalogItem));
-        when(policyCheckerService.isValid(null, null)).thenReturn(true);
         when(contractNegotiationService.negotiate(receiverEdcUrl + idsPath, catalogItem, null, null))
                 .thenReturn(null);