Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🐞[BUG] Creating notifications on tombstones #1270

Open
4 tasks
ds-crehm opened this issue Jul 23, 2024 · 1 comment
Open
4 tasks

🐞[BUG] Creating notifications on tombstones #1270

ds-crehm opened this issue Jul 23, 2024 · 1 comment
Assignees
Labels
bug Something isn't working R24.8

Comments

@ds-crehm
Copy link
Contributor

ds-crehm commented Jul 23, 2024

Links

Description

Tested on E2E in Firefox:
When creating notifications on tombstones, Trace-X stops working for me.
Additionally, it's not possible to send notifications with tombstones, but the error message is unclear.

Current behaviour

I can create a notification for tombstones, but when trying to type in a description, the application stops working and firefox reports that the page is slowing down the browser.
Image
Also, no BPN is selected and the field can't be edited, so there's no point in creating this notification as it may never be sent anywhere.

There's still the possibility that notifications for tombstones exist, as parts may be replaced by tombstones after synchronization. It's not possible to approve and send those notifications anymore, but it can be approved anyways. When doing that no error message is created and the error pop-up is not descriptive:
Image

Expected behavior

  • It may not be possible to create notifications on tombstones.
  • The "Create notification" action must be greyed out with a tooltip "It is not possible to create a quality notification for tombstones." / "Die Erstellung eines Qualitätsthemas für Grabsteine ist nicht möglich", when a tombstone is selected.
  • Tombstones may not be seen or selected in the create notification screen.
  • If a notification has a tombstone because of synchronization issues or for any other reason, the 'Approve' action is greyed out and not possible for that notification with a descriptive tooltip (e.g. "Notification can't be approved for tombstones. Please synchronize this part or select a different one.")

Steps to reproduce the Bug

Scenario 1: Creating notifications for tombstones

  1. Log in as supervisor in Trace-X A
  2. Select a tombstone
  3. Create a notification for it
  4. Application crashes

Scenario 2: Sending notifications with tombstones

  1. Log in as supervisor in Trace-X A
  2. Select any supplier part (not a tombstone)
  3. Create an investigation for it
  4. Log in as administrator in Trace-X A
  5. Create a valid policy with the BPN of Trace-X A with constraints different to the default-policy
  6. Select the supplier part from step 2
  7. Trigger the part synchronization for it -> It should now be a tombstone
  8. Log in as supervisor in Trace-X A
  9. Go to the investigation created in part 3 -> It should only have the tombstone
  10. Approve the notification -> It can't be sent
@ds-crehm ds-crehm added the bug Something isn't working label Jul 23, 2024
@ds-crehm ds-crehm changed the title 🐞[BUG] Creating notifications on tombstones breaks the application 🐞[BUG] Creating notifications on tombstones Jul 23, 2024
@ds-crehm ds-crehm added the R24.8 label Jul 23, 2024
@ds-crehm ds-crehm added the DISCUSSION_NEEDED This ticket needs discussion within teammembers label Jul 23, 2024
@ds-crehm
Copy link
Contributor Author

ds-crehm commented Jul 23, 2024

DISCUSSION_NEEDED:

  • Should users be able to create notifications for tombstones?
  • Should it be possible to send notifications with tombstones? -> If not, how should we handle that situation?

EDIT: Decision taken from #874 -> Notifications may not be created for tombstones & Notifications with tombstones may not be approved by disabling the 'Approve' action.

@ds-mwesener ds-mwesener removed the DISCUSSION_NEEDED This ticket needs discussion within teammembers label Jul 31, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working R24.8
Projects
Status: inbox
Development

No branches or pull requests

2 participants