Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[POLICY] Implement handling of notification which are revoked from receiver side because of policy expiration #639

Closed
3 tasks done
mkanal opened this issue Feb 6, 2024 · 8 comments · Fixed by #1192
Closed
3 tasks done

[POLICY] Implement handling of notification which are revoked from receiver side because of policy expiration #639

mkanal opened this issue Feb 6, 2024 · 8 comments · Fixed by #1192
Assignees
@mkanal
Labels
4 - Policy Management backend Backend related issues hardening measurements to increase resiliency policy policy management access and usage spillover temporary label for spill over

Comments

@mkanal
Copy link
Contributor

mkanal commented Feb 6, 2024 •
edited
Loading

As user
I want comprehensible message in case policy of expiration
so that I know exactly why policy was revoked

Blocked by

#787

Link

Hints / Details

  • ...

Acceptance Criteria

Out of Scope

  • ...
@mkanal mkanal mentioned this issue Feb 6, 2024
Closed
3 tasks
@mkanal mkanal changed the title Realize handling of notification which are revoked from receiver side because of policy exiration Implement handling of notification which are revoked from receiver side because of policy expiration Feb 6, 2024
@mkanal
Copy link
Contributor Author

mkanal commented Feb 6, 2024

@jzbmw pbi implementing revoking of notification

@jzbmw jzbmw added the hardening measurements to increase resiliency label Feb 15, 2024
@ds-lcapellino ds-lcapellino added the backend Backend related issues label Mar 12, 2024
@ds-crehm ds-crehm mentioned this issue Mar 13, 2024
Closed
6 tasks
@ds-mwesener ds-mwesener added the BLOCKED Issues are blocked by other issues label Apr 16, 2024
@mkanal mkanal added the policy policy management access and usage label Apr 25, 2024
@mkanal mkanal changed the title Implement handling of notification which are revoked from receiver side because of policy expiration [POLICY] Implement handling of notification which are revoked from receiver side because of policy expiration Apr 25, 2024
@ds-mmaul ds-mmaul removed the BLOCKED Issues are blocked by other issues label Apr 30, 2024
@RazvanZmau RazvanZmau added the spillover temporary label for spill over label May 28, 2024
@ds-lcapellino ds-lcapellino self-assigned this Jun 10, 2024
ds-lcapellino added a commit to catenax-ng/tx-item-relationship-service that referenced this issue Jun 10, 2024
@ds-lcapellino
feature: eclipse-tractusx/traceability-foss#639 rework handling of ex…
e6b0908 
…pired policies
ds-lcapellino added a commit to catenax-ng/tx-item-relationship-service that referenced this issue Jun 10, 2024
@ds-lcapellino
feature: eclipse-tractusx/traceability-foss#639 rework handling of ex…
0d569c5 
…pired policies
ds-lcapellino added a commit to catenax-ng/tx-item-relationship-service that referenced this issue Jun 10, 2024
@ds-lcapellino
feature: eclipse-tractusx/traceability-foss#639 rework handling of ex…
ed7eb0a 
…pired policies
ds-lcapellino added a commit to catenax-ng/tx-item-relationship-service that referenced this issue Jun 11, 2024
@ds-lcapellino
feature: eclipse-tractusx/traceability-foss#639 rework handling of ex…
527d1e9 
…pired policies
ds-lcapellino added a commit to catenax-ng/tx-item-relationship-service that referenced this issue Jun 11, 2024
@ds-lcapellino
feature: eclipse-tractusx/traceability-foss#639 rework handling of ex…
8ecc473 
…pired policies
ds-lcapellino added a commit to catenax-ng/tx-item-relationship-service that referenced this issue Jun 11, 2024
@ds-lcapellino
feature: eclipse-tractusx/traceability-foss#639 rework handling of ex…
f09c42d 
…pired policies
ds-lcapellino added a commit to catenax-ng/tx-item-relationship-service that referenced this issue Jun 11, 2024
@ds-lcapellino
feature: eclipse-tractusx/traceability-foss#639 rework handling of ex…
6657e38 
…pired policies
mkanal added a commit to eclipse-tractusx/item-relationship-service that referenced this issue Jun 11, 2024
@mkanal
Merge pull request #689 from catenax-ng/feature/639-handle-policy-exp…
6e8880b 
…iration

feature: eclipse-tractusx/traceability-foss#639 rework handling of ex…
ds-lcapellino added a commit to ds-lcapellino/traceability-foss that referenced this issue Jun 17, 2024
@ds-lcapellino
feature: eclipse-tractusx#639 update irs-lib
3b6739f
ds-lcapellino added a commit to ds-lcapellino/traceability-foss that referenced this issue Jun 17, 2024
@ds-lcapellino
feature: eclipse-tractusx#639 adapt integration tests
88b7fd5
ds-lcapellino added a commit to ds-lcapellino/item-relationship-service that referenced this issue Jun 17, 2024
@ds-lcapellino
feature: eclipse-tractusx/traceability-foss#639 add catch clause
ceae6f4
@ds-lcapellino ds-lcapellino mentioned this issue Jun 17, 2024
Merged
2 tasks
ds-lcapellino added a commit to ds-lcapellino/item-relationship-service that referenced this issue Jun 17, 2024
@ds-lcapellino
feature: eclipse-tractusx/traceability-foss#639 rework EdcClientExcep…
741f7bf 
…tion.java
ds-lcapellino added a commit to ds-lcapellino/traceability-foss that referenced this issue Jun 17, 2024
@ds-lcapellino
feature: eclipse-tractusx#639 adapt integration tests
e292065
ds-lcapellino added a commit to ds-lcapellino/item-relationship-service that referenced this issue Jun 17, 2024
@ds-lcapellino
feature: eclipse-tractusx/traceability-foss#639 rework EdcClientExcep…
89fc6ff 
…tion.java
ds-lcapellino added a commit to ds-lcapellino/traceability-foss that referenced this issue Jun 18, 2024
@ds-lcapellino
feature: eclipse-tractusx#639 fix integration tests
e1eb275
ds-lcapellino added a commit to ds-lcapellino/traceability-foss that referenced this issue Jun 18, 2024
@ds-lcapellino
feature: eclipse-tractusx#639 remove PolicyCheckerService.isValid() c…
81d839a 
…heck
@ds-mwesener
Copy link
Contributor

Reviewed the PR: #1041 (review) please see my comments.

ds-mwesener added a commit that referenced this issue Jul 4, 2024
@ds-mwesener
Merge pull request #1158 from ds-lcapellino/bug/639-update-accepted-p…
8fa48d9 
…olicies-after-crud

bug: #639 update policies provider after crud operations on policies
@ds-crehm ds-crehm mentioned this issue Jul 4, 2024
Closed
4 tasks
@ds-lcapellino
Copy link
Contributor

ds-lcapellino commented Jul 8, 2024 •
edited
Loading

The issue was fixed with the following PRs:

The issue was tested on dev as follows:

  1. With the policy API, create a new policy that is either expired or has wrong permissions
  2. create a new notification
  3. approve notification
  4. check the error message of the notification - the corresponding error of step 1. should be displayed

@ds-crehm
Copy link
Contributor

ds-crehm commented Jul 8, 2024 •
edited
Loading

Tested on E2E:

Policies don't match:
grafik
Policy of sender is expired:
grafik
This error should instead be like the first one "Failed to negotiate contract agreement: Policy [EXPIRED_POLICY_TEST] has expired."

Note:
The valid until date from the receiver is not verified. So I can send a notification to a BPN with an expired policy as long as the constraints match and my own policy is within the validUntil deadline.

Also, following bug was found - unrelated to this ticket: #1188

ds-lcapellino added a commit to eclipse-tractusx/item-relationship-service that referenced this issue Jul 9, 2024
@ds-lcapellino
bug: eclipse-tractusx/traceability-foss#639 update policy expired err…
bd10955 
…or message
ds-lcapellino added a commit to eclipse-tractusx/item-relationship-service that referenced this issue Jul 9, 2024
@ds-lcapellino
Merge pull request #774 from eclipse-tractusx/bug/#639-fix-policy-exp…
8422562 
…ired-error-message

bug: eclipse-tractusx/traceability-foss#639 update policy expired err…
ds-lcapellino added a commit that referenced this issue Jul 9, 2024
@ds-lcapellino
bug: #639 fix policy expired message
d67b10e
@github-actions github-actions bot mentioned this issue Jul 9, 2024
Merged
2 tasks
@ds-crehm ds-crehm mentioned this issue Jul 9, 2024
Open
ds-mwesener added a commit that referenced this issue Jul 10, 2024
@ds-mwesener
Merge pull request #1192 from eclipse-tractusx/bug/#639-fix-policy-ex…
790277b 
…pired-error-message

bug: #639 fix policy expired message
@mkanal mkanal reopened this Jul 10, 2024
@ds-mwesener
Copy link
Contributor

Summary of parking lot: Ticket will be moved to the review column. @ds-crehm and @mkanal will have a seperate meeting where @ds-crehm presents the use case to @mkanal

ds-lcapellino added a commit to ds-lcapellino/item-relationship-service that referenced this issue Jul 10, 2024
@ds-lcapellino
feature: eclipse-tractusx/traceability-foss#639 add interface for pol…
ebea478 
…icy exceptions
ds-lcapellino added a commit to ds-lcapellino/item-relationship-service that referenced this issue Jul 10, 2024
@ds-lcapellino
feature: eclipse-tractusx/traceability-foss#639 add catch clause and …
3a53557 
…interface for policy exceptions
@mkanal
Copy link
Contributor Author

mkanal commented Jul 10, 2024 •
edited
Loading

Image
Wrong status "ZUGESTELLT" should be "ERSTELLT" as there was an error during send process.

ds-jhartmann added a commit to eclipse-tractusx/item-relationship-service that referenced this issue Jul 10, 2024
@ds-jhartmann
Merge pull request #698 from ds-lcapellino/feature/639-handle-policy-…
da3bc67 
…expiration

feature: eclipse-tractusx/traceability-foss#639 add catch clause
@ds-lcapellino ds-lcapellino removed their assignment Jul 12, 2024
This was referenced Jul 12, 2024
Closed
Closed
Closed
@ds-crehm
Copy link
Contributor

Created the following bug ticket: #1213
As discussed, this ticket is now ready for review.

@ds-crehm ds-crehm assigned mkanal and unassigned ds-crehm Jul 15, 2024
@mkanal
Copy link
Contributor Author

mkanal commented Jul 15, 2024

LGFM. Implementation according to concept. PO acceptance in behalf of @jzbmw

@mkanal mkanal closed this as completed Jul 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@mkanal mkanal

Labels
4 - Policy Management backend Backend related issues hardening measurements to increase resiliency policy policy management access and usage spillover temporary label for spill over
Projects
Trace-X
Status: done
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

bug: #639 fix policy expired message eclipse-tractusx/traceability-foss
7 participants
@jzbmw @mkanal @ds-mmaul @ds-mwesener @ds-lcapellino @RazvanZmau @ds-crehm