Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🧐🤚[UUX] Improve user feedback after triggering notification actions #999

Closed
7 of 8 tasks
ds-crehm opened this issue May 16, 2024 · 9 comments · Fixed by #1207 or #1218
Closed
7 of 8 tasks

🧐🤚[UUX] Improve user feedback after triggering notification actions #999

ds-crehm opened this issue May 16, 2024 · 9 comments · Fixed by #1207 or #1218
Assignees
Labels
5 - Frontend Refactoring frontend Frontend related Issues uux UUX feedback and related topics
Milestone

Comments

@ds-crehm
Copy link
Contributor

ds-crehm commented May 16, 2024

Hints / Details

R24.05 UUX feedback:

-- blocking --
Upon clicking approval for just created quality investition, no indication of processing is given
Hitting Details still shows queued view,
Only a while later info at top right of page that approval processed
Table view however, does not get automatically updated / refreshed
Image

Acceptance Criteria

  • After async action from table (approve, acknowledge, accept, decline, cancel, close) has been triggered spinner is shown in status column and action menu will still show the same actions but these are disabled with a tooltip that progress is ongoing. User can still open detail view
  • In detail view after async action on while it is already in progress (same as above) the action buttons are disabled with a proper tooltip (ongoing process)
  • Loading spinner will replace the status element in the table / detail view
  • User can navigate back from detail view to the table and will see the spinner on the status column as long as it is in progress
  • Table size will not change when spinner appears
  • Loading spinner shows a tooltip with a proper message
  • User is able to trigger async actions on another notifications (also if there is progress ongoing on a different one)

Out of scope

  • Parallel sessions with different browser show the loading spinner.
@ds-crehm ds-crehm added frontend Frontend related Issues DISCUSSION_NEEDED This ticket needs discussion within teammembers concept issues describing to work on a concept uux UUX feedback and related topics labels May 16, 2024
@mkanal
Copy link
Contributor

mkanal commented Jun 21, 2024

Please add clear context why DISCUSSION NEEDED was added. @ds-crehm

@mkanal mkanal removed the DISCUSSION_NEEDED This ticket needs discussion within teammembers label Jun 21, 2024
@ds-mwesener ds-mwesener changed the title [UUX] Improve user feedback after approving notification [UUX] Improve user feedback after triggering notification actions Jul 5, 2024
@ds-mwesener ds-mwesener removed the concept issues describing to work on a concept label Jul 5, 2024
@ds-mmaul ds-mmaul self-assigned this Jul 5, 2024
ds-mwesener added a commit that referenced this issue Jul 12, 2024
…n-processing-feedback

Chore/#999 notification processing feedback
@ds-mmaul
Copy link
Contributor

✅ After async action from table (approve, acknowledge, accept, decline, cancel, close) has been triggered spinner is shown in status column and action menu will still show the same actions but these are disabled with a tooltip that progress is ongoing. User can still open detail view

✅In detail view after async action on while it is already in progress (same as above) the action buttons are disabled with a proper tooltip (ongoing process)

✅Loading spinner will replace the status element in the table / detail view

✅User can navigate back from detail view to the table and will see the spinner on the status column as long as it is in progress

✅ (Zeilenhöhe) Table size will not change when spinner appears

✅Loading spinner shows a tooltip with a proper message

✅ User is able to trigger async actions on another notifications (also if there is progress ongoing on a different one)

✅ try again supports the upper points

@ds-crehm
Copy link
Contributor Author

Tested on E2E. Works very nicely. This kind of feedback is great and the implementation is done well. All points were successfully tested.

One small issue: When switching between table view and detail view, the spinner is visible, but after the status change the status shown is still the old one. Only after manually refreshing the page the status is updated:
image
Here I acknowledged the notification in the table view and then switched to the detail view while it was still in progress. Then I get the success message but the status shown is still the old one.

@ds-crehm ds-crehm reopened this Jul 12, 2024
@ds-crehm ds-crehm removed their assignment Jul 12, 2024
ds-mmaul added a commit that referenced this issue Jul 16, 2024
…n-processing-feedback

chore(notifications): 999 fix bug
@ds-crehm
Copy link
Contributor Author

Issue from my last comment is now fixed (tested on e2e).
Status is now correctly updated after switching views during status update.

Ready for review.

@ds-crehm ds-crehm reopened this Jul 16, 2024
@ds-crehm ds-crehm assigned mkanal and unassigned ds-mmaul and ds-crehm Jul 16, 2024
@mkanal mkanal removed their assignment Jul 18, 2024
@mkanal mkanal added this to the 24.08 milestone Jul 18, 2024
@mkanal
Copy link
Contributor

mkanal commented Jul 18, 2024

#1227
#1228
Loading Supplier Table in Details View takes more than 10 seconds !!!

@mkanal
Copy link
Contributor

mkanal commented Jul 18, 2024

@ds-crehm Kindly ask to retest the story.

@ds-crehm
Copy link
Contributor Author

Tested again on E2E: LGTM
You already created the bug tickets. So those issues are addressed.

The time it took to load was because of the amount of data in the application database at the time. After an application reset the time is more reasonable again. It was not caused by the implementation of this ticket, so it can be moved to review again.

@ds-crehm ds-crehm assigned mkanal and unassigned ds-crehm Jul 19, 2024
@mkanal mkanal changed the title [UUX] Improve user feedback after triggering notification actions 🧐🤚[UUX] Improve user feedback after triggering notification actions Jul 19, 2024
@mkanal
Copy link
Contributor

mkanal commented Jul 19, 2024

Retest after application is running for some time and more than initial data are provided.

@mkanal
Copy link
Contributor

mkanal commented Jul 22, 2024

LGFM PO acceptance in behalf of @jzbmw
#1227
#1228

@mkanal mkanal closed this as completed Jul 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
5 - Frontend Refactoring frontend Frontend related Issues uux UUX feedback and related topics
Projects
Status: done
4 participants