Feature/943 update asset endpoints using post #1172

ds-mwesener · 2024-07-05T09:36:36Z

Description

Pre-review checks

Please ensure to do as many of the following checks as possible, before asking for committer review:

DEPENDENCIES are up-to-date. Dash license tool. Committers can open IP issues for restricted libs.
Copyright and license header are present on all affected files

resolves #943

… asset endpoints

feature(api):[#943] reworked autocomplete api for asBuilt & asPlanned…

github-actions · 2024-07-05T09:38:24Z

✅ No Dependency Check findings were found

github-actions · 2024-07-05T09:39:55Z

Integration Test Results

350 tests 349 ✅ 1m 43s ⏱️
41 suites 1 💤
41 files 0 ❌

Results for commit c266b5c.

♻️ This comment has been updated with latest results.

github-actions · 2024-07-05T09:40:02Z

Unit Test Results

210 tests 210 ✅ 19s ⏱️
57 suites 0 💤
57 files 0 ❌

Results for commit c266b5c.

♻️ This comment has been updated with latest results.

…alues endpoint

Feature/943 api rework

…oint

This reverts commit 094896a.

feat: rework autocomplete api for notifications endpoint

ds-mwesener · 2024-07-08T08:32:47Z

CHANGELOG.md

@@ -45,6 +45,8 @@ _**For better traceability add the corresponding GitHub issue number in each cha
 - #xxx fixed notification description on receiver side
 - #875 owasp dependency check tool is now used from github action image instead of maven plugin
 - XXX fixed display of semantic data model in parts as planned table
+- #943 renamed distinctFilterValues API to searchable-values for the asBuilt, asPlanned and notification routes
+and changed these endpoints to POST with body instead of GET with parameters


Suggested change

and changed these endpoints to POST with body instead of GET with parameters

#943 Changed these endpoints to POST with body instead of GET with parameters

Addressed in new PR

ds-mwesener · 2024-07-08T08:34:16Z

...se/tractusx/traceability/assets/application/base/request/SearchableNotificationsRequest.java

+/********************************************************************************
+ * Copyright (c) 2022, 2023 Bayerische Motoren Werke Aktiengesellschaft (BMW AG)
+ * Copyright (c) 2022, 2023 ZF Friedrichshafen AG
+ * Copyright (c) 2022, 2023 Contributors to the Eclipse Foundation


Only this line and only 2024

Addressed in new PR

ds-mwesener · 2024-07-08T08:34:21Z

...g/eclipse/tractusx/traceability/assets/application/base/request/SearchableAssetsRequest.java

+/********************************************************************************
+ * Copyright (c) 2022, 2023 Bayerische Motoren Werke Aktiengesellschaft (BMW AG)
+ * Copyright (c) 2022, 2023 ZF Friedrichshafen AG
+ * Copyright (c) 2022, 2023 Contributors to the Eclipse Foundation


Only this line and only 2024

Addressed in new PR

ds-mwesener · 2024-07-08T08:34:46Z

...se/tractusx/traceability/assets/application/base/request/SearchableNotificationsRequest.java

+import jakarta.validation.constraints.Size;
+import org.eclipse.tractusx.traceability.notification.domain.base.model.NotificationSide;
+
+public record SearchableNotificationsRequest(


Try to move the request object to tx-models

Addressed in new PR

refactor: refactor according to feedback

ds-mwesener · 2024-07-08T11:43:02Z

frontend/src/app/modules/shared/service/notification.service.ts


-    return this.apiService
-      .getBy<any>(`${ requestUrl }/distinctFilterValues`, params);
+    let body = {


ds-mwesener · 2024-07-08T11:43:12Z

frontend/src/app/modules/shared/service/parts.service.ts

-      .set('size', 200)
-      .set('inAssetIds', inAssetIds ? inAssetIds.join(',') : '');
+
+    let body = {


ds-mwesener · 2024-07-08T11:45:27Z

...rg/eclipse/tractusx/traceability/assets/application/asbuilt/rest/AssetAsBuiltController.java

        }
-        return assetBaseService.getDistinctFilterValues(fieldMapper.mapRequestFieldName(fieldName), startWith, size, owner, inAssetIdsList);
+        int size = searchableAssetsRequest.size() == null ? 200 : searchableAssetsRequest.size();


Please add default value in the request object.

ds-mmaul

LGTM

Feature/943 api rework

sonarcloud · 2024-07-10T07:00:46Z

Quality Gate failed for 'eclipse-tractusx_traceability-foss-frontend'

Failed conditions
31.2% Coverage on New Code (required ≥ 80%)

See analysis details on SonarCloud

sonarcloud · 2024-07-10T07:01:20Z

Quality Gate passed for 'Trace-X Root'

Issues
2 New issues
0 Accepted issues

Measures
0 Security Hotspots
88.9% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

ds-pweick and others added 2 commits July 5, 2024 11:34

feature(api):[#943] reworked autocomplete api for asBuilt & asPlanned…

c5dd905

… asset endpoints

Merge pull request #1171 from ds-pweick/feature/943-api-rework

b17f3ee

feature(api):[#943] reworked autocomplete api for asBuilt & asPlanned…

ds-pweick and others added 10 commits July 5, 2024 12:13

fix(api):[#943] fixed validation of requests sent to the searchable-v…

781f6be

…alues endpoint

Merge branch 'refs/heads/main' into feature/943-api-rework

2fb23eb

Merge pull request #1175 from ds-pweick/feature/943-api-rework

02f3493

Feature/943 api rework

refactor(api):[#943] reworked autocomplete api for notifications endp…

81463d2

…oint

refactor(api):[#943] removed leftover unused import

41f2aba

Merge branch 'refs/heads/main' into feature/943-api-rework

6c32b6d

refactor(api):[#943] updated OpenAPI spec

094896a

chore(docs):[#943] updated changelog

74990d2

Revert "refactor(api):[#943] updated OpenAPI spec"

7d1a754

This reverts commit 094896a.

Merge pull request #1179 from ds-pweick/feature/943-api-rework

d7fa0ff

feat: rework autocomplete api for notifications endpoint

ds-mwesener commented Jul 8, 2024

View reviewed changes

ds-pweick and others added 3 commits July 8, 2024 11:26

Merge branch 'refs/heads/main' into feature/943-api-rework

5df6247

refactor(api):[#943] refactor according to feedback

a9cfe85

Merge pull request #1185 from ds-pweick/feature/943-api-rework

b1cc47d

refactor: refactor according to feedback

ds-mwesener commented Jul 8, 2024

View reviewed changes

ds-pweick added 3 commits July 8, 2024 14:06

refactor(api):[#943] refactor according to feedback

80dea43

Merge branch 'refs/heads/main' into feature/943-api-rework

377e84c

refactor(api):[#943] refactor according to feedback

af8676e

ds-mmaul approved these changes Jul 10, 2024

View reviewed changes

Merge pull request #1187 from ds-pweick/feature/943-api-rework

c266b5c

Feature/943 api rework

ds-mwesener merged commit 5505756 into main Jul 10, 2024
23 of 24 checks passed

ds-mwesener deleted the feature/943-update-asset-endpoints-using-post branch July 10, 2024 12:09

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Feature/943 update asset endpoints using post #1172

Feature/943 update asset endpoints using post #1172

ds-mwesener commented Jul 5, 2024 •

edited

Loading

github-actions bot commented Jul 5, 2024 •

edited

Loading

github-actions bot commented Jul 5, 2024 •

edited

Loading

github-actions bot commented Jul 5, 2024 •

edited

Loading

ds-mwesener Jul 8, 2024

ds-pweick Jul 8, 2024

ds-mwesener Jul 8, 2024

ds-pweick Jul 8, 2024

ds-mwesener Jul 8, 2024

ds-pweick Jul 8, 2024

ds-mwesener Jul 8, 2024

ds-pweick Jul 8, 2024

ds-mwesener Jul 8, 2024

ds-pweick Jul 8, 2024

ds-mwesener Jul 8, 2024

ds-pweick Jul 8, 2024

ds-mwesener Jul 8, 2024

ds-pweick Jul 8, 2024

ds-mmaul left a comment

sonarcloud bot commented Jul 10, 2024

sonarcloud bot commented Jul 10, 2024

	and changed these endpoints to POST with body instead of GET with parameters
	#943 Changed these endpoints to POST with body instead of GET with parameters

Feature/943 update asset endpoints using post #1172

Feature/943 update asset endpoints using post #1172

Conversation

ds-mwesener commented Jul 5, 2024 • edited Loading

Description

Pre-review checks

github-actions bot commented Jul 5, 2024 • edited Loading

✅ No Dependency Check findings were found

github-actions bot commented Jul 5, 2024 • edited Loading

Integration Test Results

github-actions bot commented Jul 5, 2024 • edited Loading

Unit Test Results

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

ds-mmaul left a comment

Choose a reason for hiding this comment

sonarcloud bot commented Jul 10, 2024

Quality Gate failed for 'eclipse-tractusx_traceability-foss-frontend'

sonarcloud bot commented Jul 10, 2024

Quality Gate passed for 'Trace-X Root'

ds-mwesener commented Jul 5, 2024 •

edited

Loading

github-actions bot commented Jul 5, 2024 •

edited

Loading

github-actions bot commented Jul 5, 2024 •

edited

Loading

github-actions bot commented Jul 5, 2024 •

edited

Loading