Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feature: split sonar action from pr action #1375

Merged
merged 1 commit into from
Oct 17, 2024

Conversation

ds-lcapellino
Copy link
Contributor

@ds-lcapellino ds-lcapellino commented Oct 16, 2024

Description

This PR refactors the pull-request_backend.yml to split the Sonar step from the Test step. This avoids the test fail even though Sonar was not available.

Pre-review checks

Please ensure to do as many of the following checks as possible, before asking for committer review:

resolves traceability-foss#

Copy link
Contributor

github-actions bot commented Oct 16, 2024

‼️ Dependency Check findings ‼️

One or more high/critical findings have been found during dependency check. Please check the depenency report:
https://github.com/eclipse-tractusx/traceability-foss/actions/runs/11381591044

Copy link
Contributor

github-actions bot commented Oct 16, 2024

Integration Test Results

348 tests   347 ✅  1m 45s ⏱️
 41 suites    1 💤
 41 files      0 ❌

Results for commit e67792d.

♻️ This comment has been updated with latest results.

Copy link
Contributor

github-actions bot commented Oct 16, 2024

Unit Test Results

209 tests   209 ✅  20s ⏱️
 58 suites    0 💤
 58 files      0 ❌

Results for commit e67792d.

♻️ This comment has been updated with latest results.

@ds-lcapellino ds-lcapellino force-pushed the feature/seperate-sonar-action-from-tests branch 2 times, most recently from 44fc483 to 1bf6566 Compare October 16, 2024 12:47
@ds-lcapellino ds-lcapellino force-pushed the feature/seperate-sonar-action-from-tests branch from e2af543 to e67792d Compare October 17, 2024 08:51
Copy link

sonarcloud bot commented Oct 17, 2024

Copy link
Contributor

@ds-mwesener ds-mwesener left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ds-mwesener ds-mwesener merged commit dc092ce into main Oct 17, 2024
19 of 23 checks passed
@ds-mwesener ds-mwesener deleted the feature/seperate-sonar-action-from-tests branch October 17, 2024 12:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants