-
Notifications
You must be signed in to change notification settings - Fork 53
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Agreement retirement #1615
feat: Agreement retirement #1615
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
just have some nits so far, all looks great
...sx/edc/agreements/retirement/api/transform/JsonObjectFromAgreementRetirementTransformer.java
Outdated
Show resolved
Hide resolved
...a/org/eclipse/tractusx/edc/agreements/retirement/defaults/DefaultStoreProviderExtension.java
Outdated
Show resolved
Hide resolved
...va/org/eclipse/tractusx/edc/agreements/retirement/function/AgreementsRetirementFunction.java
Outdated
Show resolved
Hide resolved
...java/org/eclipse/tractusx/edc/agreements/retirement/spi/store/AgreementsRetirementStore.java
Show resolved
Hide resolved
.../org/eclipse/tractusx/edc/agreements/retirement/store/AgreementsRetirementStoreTestBase.java
Outdated
Show resolved
Hide resolved
...java/org/eclipse/tractusx/edc/agreements/retirement/spi/types/AgreementsRetirementEntry.java
Outdated
Show resolved
Hide resolved
...ava/org/eclipse/tractusx/edc/agreements/retirement/api/AgreementsRetirementApiExtension.java
Outdated
Show resolved
Hide resolved
...g/eclipse/tractusx/edc/agreements/retirement/api/v3/AgreementsRetirementApiV3Controller.java
Show resolved
Hide resolved
...g/eclipse/tractusx/edc/agreements/retirement/api/v3/AgreementsRetirementApiV3Controller.java
Outdated
Show resolved
Hide resolved
...va/org/eclipse/tractusx/edc/agreements/retirement/AgreementsRetirementFunctionExtension.java
Outdated
Show resolved
Hide resolved
...va/org/eclipse/tractusx/edc/agreements/retirement/function/AgreementsRetirementFunction.java
Outdated
Show resolved
Hide resolved
...va/org/eclipse/tractusx/edc/agreements/retirement/function/AgreementsRetirementFunction.java
Outdated
Show resolved
Hide resolved
...java/org/eclipse/tractusx/edc/agreements/retirement/spi/types/AgreementsRetirementEntry.java
Outdated
Show resolved
Hide resolved
...dc/agreements/retirement/api/transform/JsonObjectToAgreementsRetirementEntryTransformer.java
Fixed
Show fixed
Hide fixed
4cf0cf8
to
2b9bded
Compare
2b9bded
to
652d9f3
Compare
@ndr-brt I took your advise and introduced a service in between. I felt it was not needed before, but indeed it makes the API controller code more clearer. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Smol nits, but i would use ContractAgreement
in the service instead of the PolicyContext
.../org/eclipse/tractusx/edc/agreements/retirement/spi/service/AgreementsRetirementService.java
Outdated
Show resolved
Hide resolved
...s/src/test/java/org/eclipse/tractusx/edc/tests/agreement/retirement/RetireAgreementTest.java
Show resolved
Hide resolved
...sx/edc/agreements/retirement/api/transform/JsonObjectFromAgreementRetirementTransformer.java
Outdated
Show resolved
Hide resolved
...dc/agreements/retirement/api/transform/JsonObjectToAgreementsRetirementEntryTransformer.java
Outdated
Show resolved
Hide resolved
...g/eclipse/tractusx/edc/agreements/retirement/api/v3/AgreementsRetirementApiV3Controller.java
Outdated
Show resolved
Hide resolved
...dc/agreements/retirement/api/transform/JsonObjectFromAgreementRetirementTransformerTest.java
Outdated
Show resolved
Hide resolved
...lipse/tractusx/edc/agreements/retirement/api/v3/AgreementsRetirementApiV3ControllerTest.java
Outdated
Show resolved
Hide resolved
...lipse/tractusx/edc/agreements/retirement/api/v3/AgreementsRetirementApiV3ControllerTest.java
Outdated
Show resolved
Hide resolved
.../eclipse/tractusx/edc/agreements/retirement/defaults/DefaultAgreementsRetirementService.java
Outdated
Show resolved
Hide resolved
edc-extensions/agreements/retirement-evaluation-api/build.gradle.kts
Outdated
Show resolved
Hide resolved
edc-extensions/agreements/retirement-evaluation-api/build.gradle.kts
Outdated
Show resolved
Hide resolved
...dc/agreements/retirement/api/transform/JsonObjectFromAgreementRetirementTransformerTest.java
Outdated
Show resolved
Hide resolved
...x/edc/agreements/retirement/defaults/DefaultAgreementRetirementServiceProviderExtension.java
Outdated
Show resolved
Hide resolved
...usx/edc/agreements/retirement/defaults/DefaultAgreementRetirementStoreProviderExtension.java
Show resolved
Hide resolved
...g/eclipse/tractusx/edc/agreements/retirement/defaults/InMemoryAgreementsRetirementStore.java
Outdated
Show resolved
Hide resolved
...ipse/tractusx/edc/agreements/retirement/defaults/DefaultAgreementsRetirementServiceTest.java
Outdated
Show resolved
Hide resolved
...ipse/tractusx/edc/agreements/retirement/defaults/DefaultAgreementsRetirementServiceTest.java
Outdated
Show resolved
Hide resolved
.../org/eclipse/tractusx/edc/agreements/retirement/store/AgreementsRetirementStoreTestBase.java
Outdated
Show resolved
Hide resolved
.../org/eclipse/tractusx/edc/agreements/retirement/store/AgreementsRetirementStoreTestBase.java
Outdated
Show resolved
Hide resolved
@wolf4ood I changed the |
@ndr-brt I address your suggestions. The |
.../org/eclipse/tractusx/edc/agreements/retirement/spi/service/AgreementsRetirementService.java
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🚀
@rafaelmag110 just regenerate the DEPENDENCIES file then we can merge it :) |
Quality Gate passedIssues Measures |
@wolf4ood |
WHAT
Introduces a feature that enables a participant to retire an active contract agreement.
WHY
There are cases where the cancellation or update of a contract agreement might be valid, i.e. as CatenaX use cases evolve the respective frame contracts also do, and legally speaking the old contracts are no longer valid after the new version is released. There should be a way to technically retire the old agreements, effectively terminating any ongoing transfer process and disabling any new transfer request on that agreement.
FURTHER NOTES
Only in memory storage is provided for the AgreementsRetirementStore. An SQL based implementation will be provided in a following PR.
This feature only works from a provider perspective since no "agreement retirement message" is sent to the consumer. This only enables the technical retirement of an agreement after the official retirement is legally agreed upon by both parties.
Implements DR introduced in #1604
Closes eclipse-tractusx/sig-release#777