This repository has been archived by the owner on Apr 4, 2024. It is now read-only.
Fix UAttributes integer type #107
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There are a number of integer values that do not need to be signed but was set at int32 in lieu of uint32 by mistake, this change addresses the discrepancy. We also elaborate on what is means when the attribute is not present. #106
PLeVasseur
reviewed
Mar 1, 2024
sophokles73
reviewed
Mar 4, 2024
sophokles73
reviewed
Mar 4, 2024
| // UCode. If the attribute is not present, there is no communication error | ||
| optional uint32 commstatus = 8; | ||
| // If the attribute is not present, there is no communication error | ||
| optional UCode commstatus = 8; |
There was a problem hiding this comment.
FMPOV this should be changed according to the outcome of #77
There was a problem hiding this comment.
@sophokles73 are you saying the documentation would need to change but not the field name and purpose right? We might add additional UCodes but it shouldn't change the signature
There was a problem hiding this comment.
Well, communication error is quite a generic term. IMHO it could be used to indicate both a problem at the infrastructure or the application level. This is what I suggested in #77. The only thing that we need to do is to define the semantics of commstatus accordingly in the spec.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There are a number of integer values that do not need to be signed but was set at int32 in lieu of uint32 by mistake, this change addresses the discrepancy. We also elaborate on what is means when the attribute is not present.
#106