Skip to content
This repository has been archived by the owner on Apr 4, 2024. It is now read-only.

Conversation

sophokles73
Copy link
Contributor

uProtocol has several requirements for message attributes which are
independent from concrete transport protocols nor PDU mappings.

These general requirements have been added to the UAttributes definition
as a central reference.

This is the first PR addressing #71.
In a subsequent PR I will remove the corresponding UAttributes requirements from https://github.com/eclipse-uprotocol/up-spec/blob/main/basics/cloudevents.adoc

uProtocol has several requirements for message attributes which are
independent from concrete transport protocols nor PDU mappings.

These general requirements have been added to the UAttributes definition
as a central reference.
Copy link

@PLeVasseur PLeVasseur left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM aside from a couple of nits

Copy link

@PLeVasseur PLeVasseur left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving again after admitting my reading fail 😆

@stevenhartley stevenhartley merged commit cf5e53c into eclipse-uprotocol:main Mar 15, 2024
2 checks passed
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants