This repository has been archived by the owner on Apr 4, 2024. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 6
Add general requirements for message attributes #112
Merged
stevenhartley
merged 3 commits into
eclipse-uprotocol:main
from
SoftwareDefinedVehicle:define_general_uattributes_requirements
Mar 15, 2024
Merged
Add general requirements for message attributes #112
stevenhartley
merged 3 commits into
eclipse-uprotocol:main
from
SoftwareDefinedVehicle:define_general_uattributes_requirements
Mar 15, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
uProtocol has several requirements for message attributes which are independent from concrete transport protocols nor PDU mappings. These general requirements have been added to the UAttributes definition as a central reference.
PLeVasseur
reviewed
Mar 14, 2024
PLeVasseur
reviewed
Mar 14, 2024
PLeVasseur
reviewed
Mar 14, 2024
PLeVasseur
approved these changes
Mar 14, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM aside from a couple of nits
PLeVasseur
reviewed
Mar 14, 2024
PLeVasseur
reviewed
Mar 14, 2024
PLeVasseur
approved these changes
Mar 14, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Approving again after admitting my reading fail 😆
remove comment for notification type
stevenhartley
approved these changes
Mar 15, 2024
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
uProtocol has several requirements for message attributes which are
independent from concrete transport protocols nor PDU mappings.
These general requirements have been added to the UAttributes definition
as a central reference.
This is the first PR addressing #71.
In a subsequent PR I will remove the corresponding UAttributes requirements from https://github.com/eclipse-uprotocol/up-spec/blob/main/basics/cloudevents.adoc