This repository has been archived by the owner on Apr 4, 2024. It is now read-only.
Support resolved URIs #95
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In order to support resolved UAuthority, we need to pass both name and IP and/or ID, otherwise we only have partial and isResolved() for remote URIs will never be true. The change is backwards compatible. #94
| } | ||
| optional string name = 1; // Domain & device name as a string | ||
| optional bytes ip = 2; // IPv4 or IPv6 Address in byte format | ||
| optional bytes id = 3; // Unique ID for the device, could be a VIN, SHA 128, or any other identifier |
There was a problem hiding this comment.
if the id is a VIN, does that mean it does not appear in the name?
I think it is important to make this contract clear since a uE external to the vehicle usually uses the VIN in the datamodel to identify the car.
There was a problem hiding this comment.
This is vendor/OEM specific, we cannot dictate that in the protocol
tamarafischer
approved these changes
Jan 17, 2024
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In order to support resolved UAuthority, we need to pass both name and IP and/or ID, otherwise we only have partial and isResolved() for remote URIs will never be true. The change is backwards compatible.
#94