Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adding exception type for empty callback functions #301

Open
wants to merge 4 commits into
base: v1.0_up-v1.6.0
Choose a base branch
from
Open

Adding exception type for empty callback functions #301

wants to merge 4 commits into from

Commits on Aug 17, 2024

  1. Adding exception type for empty callback functions 

    This exception will be thrown when an empty std::function is passed to
the callback connection module. Adding the type first so that tests can
be written.
    @gregmedd
    gregmedd committed Aug 17, 2024
    Configuration menu
    Copy the full SHA
    9ca15f9 View commit details
    Browse the repository at this point in the history

  2. Add callback tests for empty function objects

    @gregmedd
    gregmedd committed Aug 17, 2024
    Configuration menu
    Copy the full SHA
    ae9a12d View commit details
    Browse the repository at this point in the history

  3. Fix null callback assertions in L2 tests 

    Some L2 tests were asserting that the std::bad_function_call exception
should be thrown when a bad callback is called. We will be changing that
behavior so that the exception is thrown when the callback connection is
established, requiring updated test cases.
    @gregmedd
    gregmedd committed Aug 17, 2024
    Configuration menu
    Copy the full SHA
    2f8285e View commit details
    Browse the repository at this point in the history

  4. Add empty function checks in CalleeHandle 

    The CalleeHandle class is the "owner" of the callback function objects
associated with a callback connection. As such, it will check the
validity of those function objects and throw the EmptyFunctionObject
exception if either the callback or cleanup function is empty / invalid.
    @gregmedd
    gregmedd committed Aug 17, 2024
    Configuration menu
    Copy the full SHA
    45f3dba View commit details
    Browse the repository at this point in the history