Removed unused attributes #14
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The following change removes datacontenttype and dataschema from cloudevent attributes as they are optional and not used/needed. To support this change, Jackson JSON parser needs to be explicitly told that the data is always base64 encoded. #13
LinsonI
reviewed
Aug 2, 2023
| @@ -176,8 +176,10 @@ static CloudEventBuilder buildBaseCloudEvent(String id, String source, | |||
| final CloudEventBuilder cloudEventBuilder = CloudEventBuilder.v1() | |||
| .withId(id) | |||
| .withSource(URI.create(source)) | |||
| /* Not needed: | |||
| .withDataContentType(PROTOBUF_CONTENT_TYPE) | |||
| .withDataSchema(URI.create(protoPayloadSchema)) | |||
There was a problem hiding this comment.
Can we remove the following argument from the method:
Line 174: String protoPayloadSchema,
There was a problem hiding this comment.
Removal of the argument will cause IoP issues so I prefer not to for now.
LinsonI
approved these changes
Aug 3, 2023
tamarafischer
approved these changes
Aug 10, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The following change removes datacontenttype and dataschema from cloudevent attributes as they are optional and not used/needed. To support this change, Jackson JSON parser needs to be explicitly told that the data is always base64 encoded.
#13