Use rust-protobuf instead of prost #23
Conversation
sophokles73
force-pushed
the
migrate_to_rust-protobuf
branch
from
324dd3a
to
05a3a9f
Compare
build.rs
Outdated
| fn main() -> std::io::Result<()> { | ||
| // use vendored protoc instead of relying on user provided protobuf installation | ||
| std::env::set_var("PROTOC", protoc_bin_vendored::protoc_bin_path().unwrap()); | ||
| const UPROTOCOL_BASE_URI: &str = "https://raw.githubusercontent.com/eclipse-uprotocol/uprotocol-core-api/uprotocol-core-api-1.5.4/uprotocol"; |
There was a problem hiding this comment.
@sophokles73 please pull 1.5.5, I added a fix for uAuthority
src/uuid/builder/uuidbuilder.rs
Outdated
| @@ -16,7 +16,7 @@ use std::convert::Into; | |||
| use std::sync::atomic::{AtomicU64, Ordering}; | |||
| use std::time::{SystemTime, UNIX_EPOCH}; | |||
|
|
|||
| use crate::uprotocol::Uuid as uproto_Uuid; | |||
| use crate::uprotocol::uuid::UUID as uproto_Uuid; | |||
There was a problem hiding this comment.
One thing I thought of here... looking to hear your thoughts. I don't know what the convention is, but if I'm looking for impls of UUid or its usage within this crate, I think it makes it a little harder to find due to this use foo as bar.
WDYT? Other than that, I'm good with the changes.
There was a problem hiding this comment.
I have removed the alias in the latest commit I have pushed ...
|
@stevenhartley I have upgraded to uProtocol 1.5.5 now ... |
|
@sophokles73 could you check this PR? I might have broke it while trying to merge. |
|
@stevenhartley no problem, I will rebase and squash my branch. I recommend that you do not use merge commits when merging a PR but use rebasing instead. This will provide for a much cleaner and easier to follow commit log. |
sophokles73
force-pushed
the
migrate_to_rust-protobuf
branch
from
95460d8
to
90b3f4f
Compare
The library now uses the rust-protobuf crate instead of prost to generate structs from the uProtocol proto files. All of the library's code has been adapted to the changed API while trying to maintain the library's existing external behavior. The library has also been updated to use the uProtocol 1.5.5 API.
Re-exported all public API structs from uprotocol module so that client code does not need to know about the (internal) structure of the code generated by rust-protobuf.
sophokles73
force-pushed
the
migrate_to_rust-protobuf
branch
from
90b3f4f
to
35bb108
Compare
The library now uses the rust-protobuf crate instead
of prost to generate structs from the uProtocol proto files.
All of the library's code has been adapted to the changed API
while trying to maintain the library's existing external behavior.