Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

RpcClient::invokeMethod() passing CallOptions #69

Closed
stevenhartley opened this issue Feb 21, 2024 · 5 comments
Closed

RpcClient::invokeMethod() passing CallOptions #69

stevenhartley opened this issue Feb 21, 2024 · 5 comments
Assignees
@stevenhartley
Milestone
v1.5.0-pre-alpha.2

Comments

@stevenhartley
Copy link
Contributor

Align the spec with up-java and up-rust where we pass CallOptions in lieu of UAttributes to the method as the only attribute we need is the ttl and token as the other UAttributes can be auto-generated in the implementation of invokeMethod().
@stevenhartley stevenhartley self-assigned this Feb 21, 2024
@sophokles73
Copy link
Contributor

@stevenhartley What about the message priority? Shouldn't that also be part of the CallOptions or is the priority fixed at CS4 for RPC requests?

@stevenhartley
Copy link
Contributor Author

Good point, it needs to be CS4 at least but we need to be able to set it to priority other than CS4. @sophokles73 I was thinking that CallOptions should also be defined in proto, WDYT?

@sophokles73
Copy link
Contributor

sure, I would suggest to add it to attributes.proto so that it is easier to keep consistent.

@stevenhartley
Copy link
Contributor Author

This ticket is linked to eclipse-uprotocol/up-core-api#107 that moves CallOptions to proto definition for consistency across all languages

stevenhartley pushed a commit that referenced this issue Mar 5, 2024
Update spec to match implementations
3193cd0 
The following chance replaces UAttributes with CallOptions that are defined in uattributes.proto

#69
@stevenhartley stevenhartley mentioned this issue Mar 5, 2024
Merged
stevenhartley pushed a commit that referenced this issue Mar 8, 2024
RpcClient Update to match implementations (#76)
8345997 
* Update spec to match implementations

The following chance replaces UAttributes with CallOptions that are defined in uattributes.proto

#69

* Fix the link
@stevenhartley
Copy link
Contributor Author

Merged

@stevenhartley stevenhartley added this to the v1.0.0-pre-alpha milestone Apr 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@stevenhartley stevenhartley

Labels
None yet
Projects
None yet
Milestone
v1.5.0-pre-alpha.2
Development

No branches or pull requests
2 participants
@sophokles73 @stevenhartley