Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RpcClient Update to match implementations #76

Merged
merged 2 commits into from
Mar 8, 2024
Merged

Conversation

stevenhartley
Copy link
Contributor

The following chance replaces UAttributes with CallOptions that are defined in uattributes.proto

#69

The following chance replaces UAttributes with CallOptions that are defined in uattributes.proto

#69
@@ -51,29 +51,41 @@ SPDX-License-Identifier: Apache-2.0

All link:../languages.adoc[language-specific uProtocol libraries] *MUST* declare the `RpcClient` interface with method:

`OUT Future link:../basics/umessage.adoc[UMessage] invokeMethod(IN link:../basics/uri.adoc[UUri], IN UPayload?, IN link:../basics/uattributes.adoc[UAttributes])` +
`OUT Future link:../basics/umessage.adoc[UMessage] invokeMethod(IN link:../basics/uri.adoc[UUri], IN UPayload?, IN link:../basics/.adoc[CallOptions])`
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I guess the link still needs to refer to the uattributes.adoc file?
link:../basics/uattributes.adoc[CallOptions]

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fixed

@stevenhartley stevenhartley merged commit 8345997 into main Mar 8, 2024
1 check passed
@stevenhartley stevenhartley deleted the RpcClient-Cleanup branch May 16, 2024 16:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants