You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
There is also no UnsupportedOperationException or any log to make the caller aware that this method is not doing anything right now. This is dangerous, because you think you have registered an exception handler, but in fact you have not and you will never be able to handle exceptions this way.
Version
master
The text was updated successfully, but these errors were encountered:
Actually I think exception handler in this case would not report anything useful, as this is a subscription and the class itself only relay notifications. What do you have in mind ?
Problem
When you try to regiser an exception handler in PgSubscriberImpl, the handler is never registered. See https://github.com/eclipse-vertx/vertx-sql-client/blob/master/vertx-pg-client/src/main/java/io/vertx/pgclient/impl/pubsub/PgSubscriberImpl.java#L273
There is also no
UnsupportedOperationException
or any log to make the caller aware that this method is not doing anything right now. This is dangerous, because you think you have registered an exception handler, but in fact you have not and you will never be able to handle exceptions this way.Version
master
The text was updated successfully, but these errors were encountered: