Added RGB #696
Added RGB #696
Conversation
|
This is no longer master. See https://gerrit.diamond.ac.uk/scisoft/dawnsci |
|
It's okay if you have an internal branch, I don't mind. However this version needs a fix. If you want to put your fixes back, please submit a merge request. |
|
No, this is an out-of-date repo. Checkout the new repo at the URL above. |
|
What the repo for this eclipse project is that? Seems rather unlikely. |
|
As we use Gerrit for code review, we do not use this repo any longer. All new development (since May 2018) has been at the referenced repo, |
|
That's fine but not relavent to the eclipse project "eclipse/dawnsci". You are developing the Diamond Light Source branch of dawnsci which Matthew Webber figured out would be best for DLS if it were internal. One day I hope that you will merge your branch back to this open source repo, hope springs eternal. In the meantime I need this fix or a suggestion for a better one. I cannot see https://gerrit.diamond.ac.uk/scisoft/dawnsci from the US where my proxy goes through so as project lead, I do not choose it for the eclipse/dawnsci "master" - whatever "master" really means now that DLS no longer participate in the open source project.
|
|
Try using |
|
Also mirrored at https://github.com/DawnScience/dawnsci |
|
Have these commits been through the CLA check? |
|
We are no longer developing Dawn as an Eclipse project so the CLA check does not apply. |
Seemed to be needed when saving a ILazyWriteableDataset with dtype RGB and writing slices of type RGB using setSlice(monitor, slice, sliceND);