Skip to content

Commit

Permalink
Duplicate palette icon to avoid issues when using the Palette View
Browse files Browse the repository at this point in the history
The path of the icon URI in the plugin.xml file is using the workspace
path beginning with "src/...". But in the actual bundle, this prefix
doesn't exist. This commit restore the dedicated "icons" folder which
also holds an instance of this file, which was removed with
24daefb.

See #512
  • Loading branch information
ptziegler authored and azoitl committed Aug 19, 2024
1 parent e5d6bac commit 300334c
Show file tree
Hide file tree
Showing 5 changed files with 167 additions and 1 deletion.
165 changes: 165 additions & 0 deletions icons/org.eclipse.gef/icons/palette_view.svg
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
1 change: 1 addition & 0 deletions org.eclipse.gef/build.properties
Original file line number Diff line number Diff line change
Expand Up @@ -15,6 +15,7 @@ bin.includes = about.*,\
plugin.xml,\
plugin.properties,\
css/,\
icons/,\
.,\
META-INF/
source.. = src/
Expand Down
Binary file added org.eclipse.gef/icons/palette_view.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file added org.eclipse.gef/icons/palette_view@2x.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
2 changes: 1 addition & 1 deletion org.eclipse.gef/plugin.xml
Original file line number Diff line number Diff line change
Expand Up @@ -212,7 +212,7 @@
point="org.eclipse.ui.views">
<view
name="%Palette.Label"
icon="src/org/eclipse/gef/internal/icons/palette_view.png"
icon="icons/palette_view.png"
category="org.eclipse.ui"
class="org.eclipse.gef.ui.views.palette.PaletteView"
id="org.eclipse.gef.ui.palette_view">
Expand Down

0 comments on commit 300334c

Please sign in to comment.