-
Notifications
You must be signed in to change notification settings - Fork 49
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[#155] Typed node list #234
Conversation
@Destrolaric @ptziegler could you please have a look on this change? |
org.eclipse.draw2d/src/org/eclipse/draw2d/graph/CompoundBreakCycles.java
Outdated
Show resolved
Hide resolved
org.eclipse.draw2d/src/org/eclipse/draw2d/graph/RankAssignmentSolver.java
Outdated
Show resolved
Hide resolved
org.eclipse.draw2d/src/org/eclipse/draw2d/graph/CompoundPopulateRanks.java
Outdated
Show resolved
Hide resolved
It probably would've been a little easier to split this up into separate pull requests, but I aside from those minor adaptations, I think it's looking good. |
Yes it got bigger then originally intended. Thx for the feedback. This are very nice suggestions. Will rework it accordingly. |
@ptziegler I just noticed that there is one more commit in this PR then I had intended. I hope I can get rid of it. |
581e792
to
ad59455
Compare
org.eclipse.draw2d/src/org/eclipse/draw2d/graph/CompoundBreakCycles.java
Outdated
Show resolved
Hide resolved
ad59455
to
3b4224e
Compare
org.eclipse.draw2d/src/org/eclipse/draw2d/graph/CompoundBreakCycles.java
Outdated
Show resolved
Hide resolved
3b4224e
to
010649c
Compare
Using typed generics for NodeLists. This allowed quite some code clean-up across the whole draw2d graph package. Similar changes are in work for EdgeList and RankList.
@Destrolaric I would be happy if you could have a look on this PR.