[#155] Typed node list #234
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@Destrolaric @ptziegler could you please have a look on this change? |
ptziegler
reviewed
Aug 13, 2023
org.eclipse.draw2d/src/org/eclipse/draw2d/graph/CompoundBreakCycles.java
Outdated
Show resolved
Hide resolved
ptziegler
reviewed
Aug 13, 2023
org.eclipse.draw2d/src/org/eclipse/draw2d/graph/RankAssignmentSolver.java
Outdated
Show resolved
Hide resolved
ptziegler
reviewed
Aug 13, 2023
ptziegler
reviewed
Aug 13, 2023
org.eclipse.draw2d/src/org/eclipse/draw2d/graph/CompoundPopulateRanks.java
Outdated
Show resolved
Hide resolved
ptziegler
reviewed
Aug 13, 2023
|
It probably would've been a little easier to split this up into separate pull requests, but I aside from those minor adaptations, I think it's looking good. |
Yes it got bigger then originally intended. Thx for the feedback. This are very nice suggestions. Will rework it accordingly. |
|
@ptziegler I just noticed that there is one more commit in this PR then I had intended. I hope I can get rid of it. |
azoitl
force-pushed
the
typed_node_list
branch
2 times, most recently
from
581e792
to
ad59455
Compare
ptziegler
reviewed
Aug 13, 2023
org.eclipse.draw2d/src/org/eclipse/draw2d/graph/CompoundBreakCycles.java
Outdated
Show resolved
Hide resolved
azoitl
force-pushed
the
typed_node_list
branch
from
ad59455
to
3b4224e
Compare
ptziegler
reviewed
Aug 13, 2023
org.eclipse.draw2d/src/org/eclipse/draw2d/graph/CompoundBreakCycles.java
Outdated
Show resolved
Hide resolved
azoitl
force-pushed
the
typed_node_list
branch
from
3b4224e
to
010649c
Compare
ptziegler
approved these changes
Aug 13, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Using typed generics for NodeLists. This allowed quite some code clean-up across the whole draw2d graph package. Similar changes are in work for EdgeList and RankList.
@Destrolaric I would be happy if you could have a look on this PR.