Typify dirtyRegion map in UpdateListener and UpdateManager #238
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
azoitl
reviewed
Aug 13, 2023
org.eclipse.draw2d/src/org/eclipse/draw2d/DeferredUpdateManager.java
Outdated
Show resolved
Hide resolved
ptziegler
force-pushed
the
typify-update-manager
branch
from
d4fb8f4
to
b31bd4d
Compare
This change adjusts the notifyPainting() method in UpdateListener and the firePainting() method in UpdateManager to expect a generic map of (IFigure, Rectangle) pairs, rather than a raw map. This should not cause errors in client code, as calling or overwriting this method can still be done using a raw map (which will create a "unchecked or unsafe operations" warning). Internal usage has been changed from iterators to the for-each paradigm.
ptziegler
force-pushed
the
typify-update-manager
branch
from
b31bd4d
to
e270f0d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change adjusts the notifyPainting() method in UpdateListener and the firePainting() method in UpdateManager to expect a generic map of (IFigure, Rectangle) pairs, rather than a raw map.
This should not cause errors in client code, as calling or overwriting this method can still be done using a raw map (which will create a "unchecked or unsafe operations" warning).