Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Changed shared cursors from bmps and masks to single pngs #273

Merged
merged 1 commit into from
Oct 31, 2023

Conversation

azoitl
Copy link
Contributor

@azoitl azoitl commented Oct 27, 2023

Thx to Phillipus p.beauvoir@dadabeatnik.com for providing the cursor images.

This fixes #208.

@pcdavid @Phillipus thx for reviewing.

Thx to Phillipus <p.beauvoir@dadabeatnik.com> for providing the cursor
images.
@github-actions
Copy link

Unit Test Results

     18 files       18 suites   34s ⏱️
   320 tests    318 ✔️   2 💤 0
1 920 runs  1 908 ✔️ 12 💤 0

Results for commit bbb1947.

@pcdavid
Copy link
Contributor

pcdavid commented Oct 28, 2023

I've not tested all the cursors (not even sure how to trigger most of them), but on the original scenario from the video on #208, this fixes the issue (Linux, X11, 4K screen).

@lredor
Copy link
Contributor

lredor commented Oct 30, 2023

I've not tested all the cursors (not even sure how to trigger most of them), but on the original scenario from the video on #208, this fixes the issue (Linux, X11, 4K screen).

I've tested the same scenario on Windows11: The behavior was OK before the fix, as the problem was only on Linux, and it is always OK with this PR.

@azoitl
Copy link
Contributor Author

azoitl commented Oct 31, 2023

Thanks for the feedback. I also tested all cursors under Debian/Linux with the Logic Editor example. So I think we are fine to merge.

@azoitl azoitl merged commit 04817e4 into eclipse-gef:master Oct 31, 2023
8 checks passed
@azoitl azoitl deleted the mouse_cursors branch October 31, 2023 15:42
@azoitl azoitl added this to the 3.18.0 milestone Oct 31, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[GTK] Cursor created with GIF format images renders incorrectly
3 participants