Mark Draw2D Cursors class as deprecated and for-removal #481
Conversation
|
As discussed in #479: The static Cursor objects don't support dynamic DPI changes. Meaning those instances keep using the initial display zoom, even though the level has already been changed. This is effectively just an experiment where I mark the Cursors class as deprecated and update all references with a "CursorProvider", i.e. an interface that is supposed to always return a cursor that matches the current display zoom. But even now this is already becoming a mess, as it requires changes to both the Draw2D figures and GEF tools. @azoitl wdyt? |
Using static cursors is fundamentally flawed when considering dynamic DPI changes. The static cursors created by this class are created with respect to the current display zoom. Those objects are not updated, should this value change at a later time. Clients need to listen to the SWT.ZoomChanged event and update their cursors via the CursorProvider interface.
ptziegler
force-pushed
the
depcreate-cursors
branch
from
b1cd74c
to
1e6d5e2
Compare
|
Alternatively, we could also keep this CursorProvider purely internal and push the responsibility of updating the cursor to the client. |
|
A misunderstanding on my side... The native cursors are updated upon DPI changes, but not the shared cursors. |
Using static cursors is fundamentally flawed when considering dynamic DPI changes. The static cursors created by this class are created with respect to the current display zoom. Those objects are not updated, should this value change at a later time. Clients need to listen to the SWT.ZoomChanged event and update their cursors via the CursorProvider interface.