Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cleanup GEF cursors and remove some of the blockiness #488

Draft
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

ptziegler
Copy link
Contributor

This creates SVG files for the plug/tree cursors and also the shared arrow icons, resulting in much smoother sides.

Following icons are affected:

  • arrow16
  • arrow24
  • plug-cursor
  • plugnot-cursor
  • tree_add-cursor
  • tree_move-cursor

See #465

This creates SVG files for the plug/tree cursors and also the shared
arrow icons, resulting in much smoother sides.

Following icons are affected:
- arrow16
- arrow24
- plug-cursor
- plugnot-cursor
- tree_add-cursor
- tree_move-cursor

See eclipse#465
@ptziegler
Copy link
Contributor Author

The cursors are a weird one... They are clearly based on the Windows cursors, given that the shaft is slightly tilted, making it point to a different position than the tip of the arrow.

image

And for the plug, I have no idea how to make it look prettier. I'm also not sure if we should even keep it like this. In modern UI, icons tend to be more simplistic, which causes this 3dish icon to look dated. Perhaps it'd be better to replace it with a flat image of a plug?

@azoitl
Copy link
Contributor

azoitl commented Jul 23, 2024

To add my five cents here: I never liked the connection cursors, and in 4diac IDE we are not using them for a very long time. We resorted to take the most suitable system cursor instead (e.g., crosshair for connection creation). This gives a much more native look and feel. Because any cursor we design, even if done very nice and perfect, will be wrong on any at least 2 of the 3 supported OSes.

@ptziegler
Copy link
Contributor Author

I'd have to double check, but I'm fairly certain we do the same for our product. The cursors just don't look very good. Which is also why I'm hesitant to go above and beyond here.

I tried looking into the possibility of decorating the native cursors so that one could piece together the image data, but I sadly don't believe that's possible.

@azoitl
Copy link
Contributor

azoitl commented Jul 25, 2024

I think for now it is much better then what we had before. So I would go with this change.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants