[Zest 2.0] added getter for ZestRoorLayer ordering constants #532
Conversation
| /** | ||
| * Adds a node to the ZestRootLayer | ||
| * | ||
| * @param nodeFigure The figure representing the node | ||
| */ | ||
| public void addNode(IFigure nodeFigure) { | ||
| addFigure(nodeFigure, NODES_LAYER); | ||
| addFigure(nodeFigure, getNodesLayer()); |
There was a problem hiding this comment.
I'll be honest; I don't like this at all. A getNodesLayer() method should always return NODES_LAYER. Anything else I would consider a conceptual flaw.
Can't you just overwrite the addNode(IFigure) method and then use a different constant? For example:
public void addNode(IFigure nodeFigure) {
addFigure(nodeFigure, CONNECTIONS_LAYER)
}You might have to make the changeFigureLayer() method protected to override the highlight methods, but that's fine. It still looks a little weird adding figures to other layers, but at least it's immediately obvious what's happening, when looking at it.
There was a problem hiding this comment.
Can't you just overwrite the addNode(IFigure) method and then use a different constant?
Oh... yes that makes a lot more sense. I might have been a bit blinded by the constants, that I missed I don't even have to use them.
Thank you. I will close this PR.
To be able to overwrite the ordering of the layers. See #518.