-
Notifications
You must be signed in to change notification settings - Fork 49
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make overlay scrolling configurable via the palette settings #592
Conversation
5177803
to
1107a9e
Compare
1107a9e
to
1f4082a
Compare
This adds a new checkbox to the settings dialog that allows the user to replace the overlay scrollbar with the native scrollbar. Linux only, as the overlay is not available on any other platforms. Resolves eclipse#569
1f4082a
to
1285de6
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Dumb question: Should we provide not only a preference dialog but also a preference page that users could hook into the Eclipse Platform preference dialog? Or do you expect that applications needing that would do that by themselves in app specific ways?
I think a preference page is too much, especially because we don't have any yet. At the end of the day, this whole overlay issue is something that probably only very rarely. First you have to use Linux and then you also have to explicitly enable the vertical scrollbar. It can also happen with the default configuration, but only when the editor is really small. Because the global scrollbar is never set withing GEF, this is something that has happen in user code, but then the user can simply set Hm... with a property page, it would also become a global property, so it would be very easy to enable it for palettes where you don't really want it. And for my use-case, I would want to use my own preference store, which would make things a lot more tedious... 😐 |
@ptziegler I didn't mean as part of this PR but for a new PR. However you bring quite some points that shows we shouldn't provide one even es reference in gef itself. It is maybe a better idea to have it in the Logic Editor example to serve as best practice for our uers. |
This adds a new checkbox to the settings dialog that allows the user to replace the overlay scrollbar with the native scrollbar. Linux only, as the overlay is not available on any other platforms.
Resolves #569