Make palette selection and hover colors customizable #598
Conversation
|
Contributes to #589. But with how complicated this is going to be, I think it's preferable to split it up into smaller chunks... The current state allows you to customize the colors used for selection and hover, but not e.g. the background. |
| */ | ||
| @Deprecated(forRemoval = true, since = "3.20") | ||
| public DrawerFigure(final Control control) { |
There was a problem hiding this comment.
I wonder whether it's a good or a bad idea to keep those old constructors. They're internal, so we're free to remove them without breaking API. But I know of at least one project that is using those internal classes...
There was a problem hiding this comment.
Keeping technical dept for the sake of what-ifs is probably not a good idea... Especially for something that's very easy to adapt, if user were to use those internal classes.
There was a problem hiding this comment.
I totally agree here with you. We have enough technical dept already.
ptziegler
force-pushed
the
palette-customizer-pt1
branch
3 times, most recently
from
58b2f67
to
80bcbc7
Compare
This defines a new ColorPalette interface that can be set in the PaletteViewer. The colors provided by this interface are then used in the palette figure for e.g. the tool entries. Clients can extend the DefaultColorPalette to define their own colors and therefore change the look of the palette.
ptziegler
force-pushed
the
palette-customizer-pt1
branch
from
80bcbc7
to
939f262
Compare
ptziegler
changed the title
| /** | ||
| * Flips between the custom and the default color palette whenever executed. | ||
| */ | ||
| public class ColorPaletteAction extends EditorPartAction { |
There was a problem hiding this comment.
shouldn't we use for new code the command, handler, menu extension points?
This defines a new ColorPalette interface that can be set in the PaletteViewer. The colors provided by this interface are then used in the palette figure for e.g. the tool entries.
Clients can extend the DefaultColorPalette to define their own colors and therefore change the look of the palette.