-
Notifications
You must be signed in to change notification settings - Fork 49
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make palette selection and hover colors customizable #598
base: master
Are you sure you want to change the base?
Conversation
Contributes to #589. But with how complicated this is going to be, I think it's preferable to split it up into smaller chunks... The current state allows you to customize the colors used for selection and hover, but not e.g. the background. |
*/ | ||
@Deprecated(forRemoval = true, since = "3.20") | ||
public DrawerFigure(final Control control) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I wonder whether it's a good or a bad idea to keep those old constructors. They're internal, so we're free to remove them without breaking API. But I know of at least one project that is using those internal classes...
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Keeping technical dept for the sake of what-ifs is probably not a good idea... Especially for something that's very easy to adapt, if user were to use those internal classes.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I totally agree here with you. We have enough technical dept already.
58b2f67
to
80bcbc7
Compare
This defines a new ColorPalette interface that can be set in the PaletteViewer. The colors provided by this interface are then used in the palette figure for e.g. the tool entries. Clients can extend the DefaultColorPalette to define their own colors and therefore change the look of the palette.
80bcbc7
to
939f262
Compare
/** | ||
* Flips between the custom and the default color palette whenever executed. | ||
*/ | ||
public class ColorPaletteAction extends EditorPartAction { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
shouldn't we use for new code the command, handler, menu extension points?
This defines a new ColorPalette interface that can be set in the PaletteViewer. The colors provided by this interface are then used in the palette figure for e.g. the tool entries.
Clients can extend the DefaultColorPalette to define their own colors and therefore change the look of the palette.