perfm: create array only when it is necessary at dynamic query of doc…

…ument and column Signed-off-by: Otavio Santana <otaviopolianasantana@gmail.com>
eclipse · Aug 21, 2023 · 85da543 · 85da543
1 parent 79688c9
commit 85da543
Show file tree

Hide file tree

Showing 2 changed files with 10 additions and 6 deletions.
diff --git a/...ql-mapping-column/src/main/java/org/eclipse/jnosql/mapping/column/query/DynamicQuery.java b/...ql-mapping-column/src/main/java/org/eclipse/jnosql/mapping/column/query/DynamicQuery.java
@@ -62,9 +62,11 @@ public ColumnQuery get() {
         if (limit.isPresent()) {
             long skip = limit.map(l -> l.startAt() - 1).orElse(query.skip());
             long max = limit.map(Limit::maxResults).orElse((int) query.limit());
-            List<Sort> sorts = new ArrayList<>();
-            sorts.addAll(query.sorts());
-            sorts.addAll(special.sorts());
+            List<Sort> sorts = query.sorts();
+            if (!special.sorts().isEmpty()) {
+                sorts = new ArrayList<>(query.sorts());
+                sorts.addAll(special.sorts());
+            }
             return new MappingColumnQuery(sorts, max,
                     skip,
                     query.condition().orElse(null),

diff --git a/...apping-document/src/main/java/org/eclipse/jnosql/mapping/document/query/DynamicQuery.java b/...apping-document/src/main/java/org/eclipse/jnosql/mapping/document/query/DynamicQuery.java
@@ -63,9 +63,11 @@ public DocumentQuery get() {
         if (limit.isPresent()) {
             long skip = limit.map(l -> l.startAt() - 1).orElse(query.skip());
             long max = limit.map(Limit::maxResults).orElse((int) query.limit());
-            List<Sort> sorts = new ArrayList<>();
-            sorts.addAll(query.sorts());
-            sorts.addAll(special.sorts());
+            List<Sort> sorts = query.sorts();
+            if (!special.sorts().isEmpty()) {
+                sorts = new ArrayList<>(query.sorts());
+                sorts.addAll(special.sorts());
+            }
             return new MappingDocumentQuery(sorts, max,
                     skip,
                     query.condition().orElse(null),