Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: show correct icons in barnim scenario #422

Merged

Conversation

hoelger
Copy link
Contributor

@hoelger hoelger commented Oct 8, 2024

Description

The Barnim Scenario was showing only ? icons. This PR provides a fix for this.

Issue(s) related to this PR

  • Resolves internal issue 893

Affected parts of the online documentation

Changes in the documentation required? No.

Definition of Done

Prerequisites

  • You have read CONTRIBUTING.md carefully.
  • You have signed the Contributor License Agreement.
  • Your GitHub user id is linked with your Eclipse Account.

Required

  • The title of this merge request follows the scheme type(scope): description (in the style of Conventional Commits)
  • You have assigned a suitable label to this pull request (e.g., enhancement, or bugfix)
  • origin/main has been merged into your Fork.
  • Coding guidelines have been followed (see CONTRIBUTING.md).
  • All checks on GitHub pass.
  • All tests on Jenkins pass.

Requested (can be enforced by maintainers)

  • New functionality is covered by unit tests or integration tests. Code coverage must not decrease.
  • If a bug has been fixed, a new unit test has been written (beforehand) to prove misbehavior
  • There are no new SpotBugs warnings.

Special notes to reviewer

@hoelger hoelger force-pushed the 893-fix-webvisualizer-icons-barnim-scenario branch from 5d55e61 to d8f0030 Compare October 9, 2024 08:40
@kschrab kschrab added the bugfix Pull requests that fixes a bug label Oct 9, 2024
@kschrab kschrab merged commit 4f7f1d7 into eclipse:main Oct 9, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bugfix Pull requests that fixes a bug hacktoberfest-accepted
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants