feat: Add basic key-value pair field support #3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thank you for your submission @lpraneis! I'll have a look and provide feedback shortly. |
pnehrer
reviewed
Apr 22, 2024
There was a problem hiding this comment.
Thank you again! I spent some time thinking about how to serialize slog's key/value pairs "natively" but couldn't think of a way as tracking handles these quite differently.
Would you mind calling this addition kv instead of fields? That name is quite overloaded in the context of tracing.
Also, I'd prefer the whole feature to be opt-in, for starters.
Co-authored-by: Peter Nehrer <pnehrer@eclipticalsoftware.com>
Co-authored-by: Peter Nehrer <pnehrer@eclipticalsoftware.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi @pnehrer , thanks for the useful crate!
I recently used this crate in a project that made heavy use of the
slogsupport for key value pairs and added some basic support to this library for serializing those to a new field,slog.fieldsand thought I would contribute that change upstream in case it would be useful for others as well.Feel free to decline this PR if you don't think this kind of addition makes sense here. I gated the new functionality behind a
kvfeature because it does have some slight allocation overhead per log generated if a key-value pair is in use. I made this feature opt-out but would be happy to swap that to opt-in.