fix: Set Firebase Functions v2 names with one word at all

Snake case also not working https://github.com/ecomplus/store/runs/7687019705\?check_suite_focus\=true Fix pubsub trigerred functions region
ecomplus · Aug 5, 2022 · 23d5f17 · 23d5f17
1 parent fcb882c
commit 23d5f17
Show file tree

Hide file tree

Showing 4 changed files with 16 additions and 13 deletions.
diff --git a/packages/events/src/firebase.ts b/packages/events/src/firebase.ts
@@ -4,16 +4,18 @@ import type { AppEventsTopic } from '@cloudcommerce/types';
 import 'source-map-support/register.js';
 // eslint-disable-next-line import/no-unresolved
 import { initializeApp } from 'firebase-admin/app';
-// eslint-disable-next-line import/no-unresolved
-import { runWith, logger } from 'firebase-functions';
+import functions from 'firebase-functions';
+import config from '@cloudcommerce/firebase/lib/config';
 
+const { logger } = functions;
 initializeApp();
 
 const eventMaxAgeMs = 60000;
 const newOrderTopic: AppEventsTopic = 'orders-new';
+const { httpsFunctionOptions: { region } } = config.get();
 
-// eslint-disable-next-line camelcase
-export const on_new_order = runWith({ failurePolicy: true })
+export const onNewOrder = functions.region(region)
+  .runWith({ failurePolicy: true })
   .pubsub.topic(newOrderTopic).onPublish((message, context) => {
     const eventAgeMs = Date.now() - Date.parse(context.timestamp);
     if (eventAgeMs > eventMaxAgeMs) {

diff --git a/packages/firebase/src/index.ts b/packages/firebase/src/index.ts
@@ -5,12 +5,15 @@ import '@cloudcommerce/api/fetch-polyfill.js';
 // https://github.com/import-js/eslint-plugin-import/issues/1810
 // eslint-disable-next-line import/no-unresolved
 import { initializeApp } from 'firebase-admin/app';
-import { pubsub } from 'firebase-functions';
+import functions from 'firebase-functions';
+import config from './config';
 import checkStoreEvents from './handlers/check-store-events';
 
 initializeApp();
 
-// eslint-disable-next-line camelcase
-export const cron_store_events = pubsub.schedule('* * * * *').onRun(() => {
-  return checkStoreEvents();
-});
+const { httpsFunctionOptions: { region } } = config.get();
+
+export const cronStoreEvents = functions.region(region)
+  .pubsub.schedule('* * * * *').onRun(() => {
+    return checkStoreEvents();
+  });
diff --git a/packages/modules/src/firebase.ts b/packages/modules/src/firebase.ts
@@ -12,8 +12,7 @@ import serveModulesApi from './firebase/serve-modules-api';
 initializeApp();
 const { httpsFunctionOptions } = config.get();
 
-// eslint-disable-next-line camelcase
-export const modules_api = onRequest(httpsFunctionOptions, (req, res) => {
+export const modules = onRequest(httpsFunctionOptions, (req, res) => {
   const { authenticationId, apiKey } = getEnv();
   // Hide API key for security
   process.env.ECOM_API_KEY = '***';

diff --git a/packages/passport/src/firebase.ts b/packages/passport/src/firebase.ts
@@ -10,8 +10,7 @@ import config from '@cloudcommerce/firebase/lib/config';
 initializeApp();
 const options = config.get().httpsFunctionOptions;
 
-// eslint-disable-next-line camelcase
-export const passport_api = onRequest(options, (request, response) => {
+export const passport = onRequest(options, (request, response) => {
   process.env.ECOM_API_KEY = '***';
   response.send('Hello passport!');
 });