fix(storefront): Dropping apiContext.timestamp to support etag cach…

…ing on output HTML
ecomplus · Oct 23, 2024 · 6231f2d · 6231f2d
1 parent 27861d3
commit 6231f2d
Show file tree

Hide file tree

Showing 3 changed files with 1 addition and 6 deletions.
diff --git a/packages/storefront/src/lib/$storefront.d.ts b/packages/storefront/src/lib/$storefront.d.ts
@@ -11,19 +11,15 @@ import type { CustomSharedData } from '@@sf/custom-shared-data';
 export type StorefrontApiContext = {
   resource: 'products',
   doc: Products,
-  timestamp: number,
 } | {
   resource: 'categories',
   doc: Categories,
-  timestamp: number,
 } | {
   resource: 'brands',
   doc: Brands,
-  timestamp: number,
 } | {
   resource: 'collections',
   doc: Collections,
-  timestamp: number,
 };
 
 export type $Storefront = {

diff --git a/packages/storefront/src/lib/layouts/BaseHead.astro b/packages/storefront/src/lib/layouts/BaseHead.astro
@@ -129,7 +129,7 @@ window._firstLoadContextId = '${apiDoc._id}';`;
 $storefront.apiContext = ${JSON.stringify({
     resource: apiContext.resource,
     doc: minifyApiDoc({ ...apiDoc }),
-    timestamp: Date.now(),
+    // timestamp: Date.now(),
   })};
 $storefront.context /* DEPRECATED */ = $storefront.apiContext;
 _emitApiContext('${apiDoc._id}');`;

diff --git a/packages/storefront/src/lib/ssr-context.ts b/packages/storefront/src/lib/ssr-context.ts
@@ -216,7 +216,6 @@ const loadRouteContext = async (
             sessions[sid].apiContext = {
               resource: apiResource,
               doc: apiDoc,
-              timestamp: Date.now(),
             };
             sessions[sid]._timer = setTimeout(() => {
               // @ts-expect-error: mem clearing