From ff135732f8e02f03e946df85eb78a5f960907a30 Mon Sep 17 00:00:00 2001 From: Leonardo Matos Date: Thu, 31 Aug 2023 23:21:24 -0300 Subject: [PATCH] perf(storefront): Register SW after page load with default workbox behavior Expecting to reduce TBT Following https://web.dev/service-workers-registration/\#conclusion and https://developer.chrome.com/docs/workbox/using-workbox-window/\#registering-a-service-worker --- packages/storefront/src/lib/layouts/BaseHead.astro | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/packages/storefront/src/lib/layouts/BaseHead.astro b/packages/storefront/src/lib/layouts/BaseHead.astro index ae9a51f98..b1f3f8bae 100644 --- a/packages/storefront/src/lib/layouts/BaseHead.astro +++ b/packages/storefront/src/lib/layouts/BaseHead.astro @@ -29,7 +29,7 @@ if (fetchingApiContext) { const apiDoc = apiContext.doc; const state: Record = apiDoc || cmsContent || {}; -const title = state.meta_title || state.name || state.title || Astro.props.title || settings.name; +const title = state.meta_title || state.name || state.title || settings.name; const description = state.meta_description || state.short_description || settings.description; const favicon = settings.icon ? getIconUrl(32) : '/favicon.ico'; const shortcutIcon = settings.icon ? getIconUrl(192) : null; @@ -137,9 +137,10 @@ const inlineJSONLd = JSON.stringify({ {metatagsContent?.twitter_username && } + {pwaInfo && } {(!pwaInfo && !import.meta.env.DEV) &&