Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP] Interpolation overhaul #1203

Open
wants to merge 97 commits into
base: master
Choose a base branch
from

Conversation

alanlujan91
Copy link
Member

@alanlujan91 alanlujan91 commented Jan 9, 2023

Please ensure your pull request adheres to the following guidelines:

  • Tests for new functionality/models or Tests to reproduce the bug-fix in code.
  • Updated documentation of features that add new functionality.
  • Update CHANGELOG.md with major/minor changes.

@sbenthall
Copy link
Contributor

#1242 is about the EconForge interpolator as an additional backend to multivariate interpolation?

Copy link
Collaborator

@llorracc llorracc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Small comment: My pref is to be more systematic about naming, and have the general followed by the specific. Like, it should be interp_bilinear, interp_decay, interp_linear. Also, is LinearFast an interpolator? If so it should be interp_linear_fast

@codecov
Copy link

codecov bot commented May 16, 2023

Codecov Report

Patch coverage: 53.90% and project coverage change: -0.54 ⚠️

Comparison is base (2209109) 72.55% compared to head (18f4329) 72.01%.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1203      +/-   ##
==========================================
- Coverage   72.55%   72.01%   -0.54%     
==========================================
  Files          78       85       +7     
  Lines       13009    13391     +382     
==========================================
+ Hits         9439     9644     +205     
- Misses       3570     3747     +177     
Impacted Files Coverage Δ
HARK/interpolation/_econforge.py 90.36% <ø> (ø)
HARK/interpolation/_hark.py 43.31% <ø> (ø)
HARK/interpolation/tests/test_hark.py 100.00% <ø> (ø)
HARK/interpolation/_sklearn.py 39.82% <39.82%> (ø)
HARK/interpolation/_multi.py 41.98% <41.98%> (ø)
HARK/interpolation/_scipy.py 85.18% <85.18%> (ø)
HARK/interpolation/__init__.py 100.00% <100.00%> (ø)
HARK/interpolation/tests/test_econforge.py 100.00% <100.00%> (ø)
HARK/interpolation/tests/test_multi.py 100.00% <100.00%> (ø)
HARK/interpolation/tests/test_scipy.py 100.00% <100.00%> (ø)
... and 1 more

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants