Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Restructure navigation #1302

Merged
merged 23 commits into from
Jul 14, 2023
Merged

Restructure navigation #1302

merged 23 commits into from
Jul 14, 2023

Conversation

AA-Turner
Copy link
Collaborator

This PR restructures the top-level navigation. I used the Diátaxis framework for general design guideance and several homepages of popular projects (e.g. NumPy) for applied navigation.

I've organised as follows as a suggestion:

  • 'Overview' -- all example notebooks, and the two prose documents explaining the background and context of HARK -- this fits the 'explanation' category of Diátaxis
  • 'Reference' -- this is the current reference section
  • 'Guides' -- this is currently the quick start, installation, and contribution guides, but could grow to encompass tutorial style content

The notebooks were somewhat challenging to classify as tutorial (learning-first) vs explanation (understanding-first), but for ease I've put them all in explanation for now. Tutorial is the major missing Diátaxis category currently.

A

cc: @MridulS

(this PR is based on top of #1301; please review that one first!)

@review-notebook-app
Copy link

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.


Powered by ReviewNB

@codecov
Copy link

codecov bot commented Jul 13, 2023

Codecov Report

Patch and project coverage have no change.

Comparison is base (09f1843) 72.55% compared to head (510c992) 72.55%.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #1302   +/-   ##
=======================================
  Coverage   72.55%   72.55%           
=======================================
  Files          78       78           
  Lines       13009    13009           
=======================================
  Hits         9439     9439           
  Misses       3570     3570           

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@MridulS
Copy link
Member

MridulS commented Jul 13, 2023

Thanks @AA-Turner!

Urghh, looks like the #1301 merge created too many merge conflicts. Could you rebase and push?

# Conflicts:
#	Documentation/index.rst
#	Documentation/reference/tools/index.rst
@AA-Turner
Copy link
Collaborator Author

Done!

@MridulS
Copy link
Member

MridulS commented Jul 13, 2023

Some notes:

The references section behave differently for the tools sections and the models section (Not sure if it's a local issue for me). The sidebar on left goes away for tools section.

While we are on diataxis, can we get the pretty blocks like https://docs.scipy.org/doc/scipy/ for the homepage? (Doesn't need to happen in this PR)

@AA-Turner
Copy link
Collaborator Author

The references section behave differently for the tools sections and the models section (Not sure if it's a local issue for me). The sidebar on left goes away for tools section.

Fixed, thanks for spotting -- an odd interaction that I'll look into in Sphinx.

While we are on diataxis, can we get the pretty blocks like https://docs.scipy.org/doc/scipy/ for the homepage? (Doesn't need to happen in this PR)

Yep!

A

@llorracc
Copy link
Collaborator

llorracc commented Jul 14, 2023 via email

@AA-Turner
Copy link
Collaborator Author

@llorracc -- do you have Dominic's GitHub account name to hand please at all? I can then add him to the reviewers group for each PR I open.

Thanks,
Adam

@llorracc
Copy link
Collaborator

llorracc commented Jul 14, 2023 via email

@alanlujan91
Copy link
Member

@DominicWC

@MridulS
Copy link
Member

MridulS commented Jul 14, 2023

This looks good! Thanks @AA-Turner!

@MridulS MridulS merged commit 2209109 into econ-ark:master Jul 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants