Labeled dist-of-fun #1306
Merged
Labeled dist-of-fun #1306
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## master #1306 +/- ##
==========================================
+ Coverage 72.55% 72.64% +0.08%
==========================================
Files 78 78
Lines 13009 13028 +19
==========================================
+ Hits 9439 9464 +25
+ Misses 3570 3564 -6
☔ View full report in Codecov by Sentry. |
alanlujan91
approved these changes
Jul 26, 2023
alanlujan91
reviewed
Jul 26, 2023
| ldd = DiscreteDistributionLabeled.from_dataset(f_query, self.pmv) | ||
| ldd = DiscreteDistributionLabeled.from_dataset(f_query, self.probability) |
There was a problem hiding this comment.
should probably standardize this with DiscreteDistribution ... that's on me
There was a problem hiding this comment.
Yeah this was the only kind of "bug" this addresses; it makes some cases work that didn't before.
The other stuff is a design question. Happy to merge this in without resolving that, but also happy to have a conversation, agree, and implement it.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Aims to fix: #1290
Still need to reach consensus with @alanlujan91 on whether the different behavior of
dist_of_funcandespecteddepending on the class of their input is a feature, a bug, or a temporary solution.