Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use a gallery for the example notebooks #1321

Merged
merged 4 commits into from
Aug 5, 2023

Conversation

AA-Turner
Copy link
Collaborator

cc: @MridulS @DominicWC

This converts the list of example notebooks to a 'gallery' preview that looks slightly nicer. The titles of some of the notebooks were very long, so I took liberties to rename them.

A

@codecov
Copy link

codecov bot commented Jul 24, 2023

Codecov Report

Patch and project coverage have no change.

Comparison is base (a547d08) 72.64% compared to head (6ab3b4d) 72.64%.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #1321   +/-   ##
=======================================
  Coverage   72.64%   72.64%           
=======================================
  Files          78       78           
  Lines       13028    13028           
=======================================
  Hits         9464     9464           
  Misses       3564     3564           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@DominicWC
Copy link
Collaborator

DominicWC commented Jul 27, 2023

Would it be possible to add every single Notebook from the "Consumption Savings" folder in the examples section of hark into the documentation?
Or at least the most fully developed ones? Ideally we'd have a full document for every single model HARK includes, but it seems weird to have some of the most helpful documentation for new HARK learners buried away in the source code with no easy way to access it.

@MridulS
Copy link
Member

MridulS commented Jul 31, 2023

Ideally we'd have a full document for every single model HARK includes, but it seems weird to have some of the most helpful documentation for new HARK learners buried away in the source code with no easy way to access it.

For this bit we should improve our inline docs in the code. That would make our reference section much cleaner and users are expected to look at the API reference instead of us creating examples for every single model.

@DominicWC
Copy link
Collaborator

If we want users to look at the API reference then we'd want to structure it more like NumPy's with a written description of all the aspects of a function, and examples of it being used, rather than just using AutoDocs.

@MridulS
Copy link
Member

MridulS commented Aug 5, 2023

If we want users to look at the API reference then we'd want to structure it more like NumPy's with a written description of all the aspects of a function, and examples of it being used, rather than just using AutoDocs.

I agree, numpy is also just autodocs. It's just their inline docs are much better :D

@MridulS MridulS merged commit be362fb into econ-ark:master Aug 5, 2023
17 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants