Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding url for GICRaw #1338

Closed
wants to merge 0 commits into from
Closed

Adding url for GICRaw #1338

wants to merge 0 commits into from

Conversation

dedwar65
Copy link
Contributor

@dedwar65 dedwar65 commented Aug 8, 2023

Please ensure your pull request adheres to the following guidelines:

  • Tests for new functionality/models or Tests to reproduce the bug-fix in code.
  • Updated documentation of features that add new functionality.
  • Update CHANGELOG.md with major/minor changes.

@codecov
Copy link

codecov bot commented Aug 8, 2023

Codecov Report

Patch and project coverage have no change.

Comparison is base (4f644bf) 72.64% compared to head (e1b5d35) 72.64%.

❗ Current head e1b5d35 differs from pull request most recent head 446085d. Consider uploading reports for the commit 446085d to get more accurate results

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #1338   +/-   ##
=======================================
  Coverage   72.64%   72.64%           
=======================================
  Files          78       78           
  Lines       13028    13028           
=======================================
  Hits         9464     9464           
  Misses       3564     3564           
Files Changed Coverage Δ
HARK/ConsumptionSaving/ConsIndShockModel.py 87.04% <ø> (ø)

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@alanlujan91
Copy link
Member

@dedwar65 this seems to be breaking 2 tests which should be easy to fix

FAILED HARK/ConsumptionSaving/tests/test_IndShockConsumerType.py::testBufferStock::test_GICRawFails - KeyError: 'GICRaw'
FAILED HARK/ConsumptionSaving/tests/test_IndShockConsumerTypeFast.py::testBufferStock::test_GICRawFails - KeyError: 'GICRaw'
=========== 2 failed, 190 passed, 166 warnings in 630.65s (0:10:30) ============

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants