Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tracking bug in bequest portfolio consumer model check #1385

Closed
wants to merge 3 commits into from

Conversation

alanlujan91
Copy link
Member

Please ensure your pull request adheres to the following guidelines:

  • Tests for new functionality/models or Tests to reproduce the bug-fix in code.
  • Updated documentation of features that add new functionality.
  • Update CHANGELOG.md with major/minor changes.

Copy link

codecov bot commented Feb 19, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 71.69%. Comparing base (638c5ca) to head (bb92a90).
Report is 57 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1385      +/-   ##
==========================================
+ Coverage   71.58%   71.69%   +0.10%     
==========================================
  Files          84       84              
  Lines       13929    13939      +10     
==========================================
+ Hits         9971     9993      +22     
+ Misses       3958     3946      -12     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@alanlujan91
Copy link
Member Author

@dedwar65 as you can see from the checks the problem here wasn't the notebook not running.

@alanlujan91
Copy link
Member Author

@dedwar65 this all runs locally on my end.

Also, please see that the check that runs the notebooks is passing, meaning all the notebooks are running without issue, including the ones you have added to this PR.

I think this might be an issue with your local installation.

@alanlujan91
Copy link
Member Author

this is superseded by #1392

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants