Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Simplify pre-commit usage #1396

Merged
merged 3 commits into from
Mar 11, 2024
Merged

Simplify pre-commit usage #1396

merged 3 commits into from
Mar 11, 2024

Conversation

MridulS
Copy link
Member

@MridulS MridulS commented Mar 9, 2024

This move the pre-commit config to use the inbuilt ruff formatter and ruff for linter all over HARK.

@MridulS MridulS requested a review from alanlujan91 March 9, 2024 18:03
@llorracc
Copy link
Collaborator

@MridulS,

Sounds like a good idea, but tests are failing ...

@alanlujan91
Copy link
Member

A quick look seems to indicate the failing tests are unrelated to @MridulS's changes. I'll take a look later today

Copy link

codecov bot commented Mar 11, 2024

Codecov Report

Attention: Patch coverage is 87.50000% with 4 lines in your changes are missing coverage. Please review.

Project coverage is 71.71%. Comparing base (df9b60c) to head (bca2586).

Files Patch % Lines
HARK/ConsumptionSaving/ConsRiskyContribModel.py 0.00% 2 Missing ⚠️
HARK/tests/OpenCLtest.py 0.00% 1 Missing ⚠️
HARK/utilities.py 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1396      +/-   ##
==========================================
- Coverage   71.72%   71.71%   -0.01%     
==========================================
  Files          84       83       -1     
  Lines       13910    13903       -7     
==========================================
- Hits         9977     9971       -6     
+ Misses       3933     3932       -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@alanlujan91 alanlujan91 mentioned this pull request Mar 11, 2024
@mnwhite
Copy link
Contributor

mnwhite commented Mar 11, 2024

Merging this now. The 4 lines alleged by codecov not to be covered don't appear to actually exist-- it won't show me any uncovered changes.

@mnwhite mnwhite merged commit bbb07a5 into econ-ark:master Mar 11, 2024
18 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants