Counterpart example notebooks for bequests with portfolio choice #1398
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Notebooks featuring the bequest portfolio consumer type almost complete. There is a minor issue in the notebooks: for some reason, the accidental and terminal bequest portfolio types are returning the same consumption functions and wealth moments. This obviously should not occur, since the dictionary creates instances with different parameter values.
|
@dedwar65 is this done? can you resolve conflicts? |
|
If you recall, in the HARK meeting before last you told me to make a pull request with the changes to the example notebooks. The notebooks ran, but there is a final discrepancy that needs to be resolved. It shouldn’t be causing anything to break though.
I am not too sure how to resolve the conflict on my end but I will look into it.
From: Alan Lujan ***@***.***>
Date: Friday, April 5, 2024 at 2:44 PM
To: econ-ark/HARK ***@***.***>
Cc: Decory Edwards ***@***.***>, Mention ***@***.***>
Subject: Re: [econ-ark/HARK] Counterpart example notebooks for bequests with portfolio choice (PR #1398)
External Email - Use Caution
@dedwar65<https://github.com/dedwar65> is this done? can you resolve conflicts?
—
Reply to this email directly, view it on GitHub<#1398 (comment)>, or unsubscribe<https://github.com/notifications/unsubscribe-auth/AR3YDSM5UJZGPZN2NINKHBLY33WIDAVCNFSM6AAAAABEXBN5U6VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDANBQGQZDQMRXGY>.
You are receiving this because you were mentioned.Message ID: ***@***.***>
|
need to check some errors in notebooks
|
hoping this works now and that I didn't break anything else @dedwar65 if this passes all tests, can you review the notebooks and add some descriptive narrative to the examples? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull request is nearly complete. Some small discrepancies need to be sorted. Lastly, Something regarding the optimal shares in the model should be added.