InstagramAds

phpunit.xml

@@ -8,9 +8,7 @@
          convertWarningsToExceptions="true"
          processIsolation="false"
          stopOnFailure="false"
-         syntaxCheck="false"
-         verbose="true"
->
+         verbose="true">
     <testsuites>
         <testsuite name="Laravel Facebok Ads Test Suite">
             <directory suffix=".php">./tests</directory>
@@ -22,8 +20,7 @@
         </whitelist>
     </filter>
     <logging>
-        <log type="coverage-html" target="build/coverage" charset="UTF-8" yui="true" highlight="true"/>
+        <log type="coverage-html" target="build/coverage"/>
         <log type="coverage-text" target="build/coverage.txt"/>
-        <log type="coverage-clover" target="build/logs/clover.xml"/>
     </logging>
 </phpunit>

src/AbstractFacebookAds.php

@@ -4,21 +4,21 @@
 
 use FacebookAds\Api;
 use Edbizarro\LaravelFacebookAds\Contracts\LaravelFacebookAdsContract;
+use Illuminate\Support\Traits\Macroable;
 
 /**
  * Class AbstractFacebookAds.
  */
 abstract class AbstractFacebookAds implements LaravelFacebookAdsContract
 {
+    use Macroable;
+
     /**
      * @var Api
      */
     protected $adsApiInstance;
 
-    /**
-     * {@inheritdoc}
-     */
-    public function init($accessToken)
+    public function init($accessToken): FacebookAds
     {
         Api::init(
             config('facebook-ads.app_id'),

src/Contracts/LaravelFacebookAdsContract.php

@@ -16,5 +16,5 @@ interface LaravelFacebookAdsContract
      *
      * @return FacebookAds
      */
-    public function init($accessToken);
+    public function init($accessToken): FacebookAds;
 }

src/Entities/AbstractEntity.php

@@ -2,14 +2,18 @@
 
 namespace Edbizarro\LaravelFacebookAds\Entities;
 
+use FacebookAds\Object\AbstractObject;
 use Illuminate\Contracts\Support\Arrayable;
 
 /**
  * Class Entity.
  */
 abstract class AbstractEntity implements Arrayable
 {
-    protected $response = [];
+    /**
+     * @var AbstractObject|array
+     */
+    protected $response;
 
     public function __construct($class = [])
     {

src/Entities/AdAccount.php

@@ -24,7 +24,8 @@ class AdAccount extends AbstractEntity
      */
     public function ads(array $fields = []): Collection
     {
-        $ads = $this->response->getAds($fields);
-        return $this->format($ads);
+        return $this->format(
+            $this->response->getAds($fields)
+        );
     }
 }

src/Entities/Insights.php

@@ -19,14 +19,14 @@ class Insights
      * List all campaigns.
      *
      * @param array $fields
-     * @param string $accountId
+     * @param string $accountId *
      *
-     * @return Collection
+     * @return \FacebookAds\Object\AbstractObject|Collection
      *
-     * @see https://developers.facebook.com/docs/marketing-api/reference/ad-account/campaigns
      * @throws \Edbizarro\LaravelFacebookAds\Exceptions\MissingEntityFormatter
+     * @see https://developers.facebook.com/docs/marketing-api/reference/ad-account/campaigns
      */
-    public function all(array $fields, string $accountId): Collection
+    public function all(array $fields, string $accountId)
     {
         return $this->format(
             (new AdAccount)->setId($accountId)->getCampaigns($fields)

src/Entities/InstagramAccounts.php

@@ -24,7 +24,7 @@ class InstagramAccounts
      * @throws \Edbizarro\LaravelFacebookAds\Exceptions\MissingEntityFormatter
      * @see https://developers.facebook.com/docs/marketing-api/guides/instagramads
      */
-    public function all(array $fields = [], $accountId = 'me'): Collection
+    public function all(array $fields, $accountId): Collection
     {
         return $this->format(
             (new FbAdAccount($accountId))->getInstagramAccounts($fields)

tests/LaravelFacebookAds/BaseTest.php

@@ -2,6 +2,7 @@
 
 namespace LaravelFacebookAds\Tests;
 
+use Edbizarro\LaravelFacebookAds\Providers\LaravelFacebookServiceProvider;
 use Mockery as m;
 use Orchestra\Testbench\TestCase;
 
@@ -10,14 +11,19 @@
  */
 class BaseTest extends TestCase
 {
-    public function tearDown()
+    public function tearDown(): void
     {
         parent::tearDown();
         m::close();
     }
 
-    public function setUp()
+    public function setUp(): void
     {
         parent::setUp();
     }
+
+    protected function getPackageProviders($app)
+    {
+        return [LaravelFacebookServiceProvider::class];
+    }
 }