Adds various check for config files presence and validity

Add checks for empty or non existent config file
Add check for existing contexts folder
Add viper config file consistency check

Signed-off-by: Eddy Babetto <eddy.babetto@secomind.com>

cmd/cluster/instance_get_cluster_config.go

@@ -103,18 +103,7 @@ func doGetClusterConfig(resourceName, resourceNamespace string) error {
 	fmt.Printf("Created new Context %s\n", contextName)
 
 	// Now set the current context to the new one
-	baseConfig, err := config.LoadBaseConfiguration(configDir)
-	if err != nil {
-		// Shoot out a warning, but don't fail
-		baseConfig = config.BaseConfigFile{}
-		fmt.Fprintf(os.Stderr, "warn: Could not load configuration file: %s. Will proceed creating a new one\n", err.Error())
-	}
-
-	baseConfig.CurrentContext = contextName
-	if err := config.SaveBaseConfiguration(configDir, baseConfig); err != nil {
-		fmt.Fprintln(os.Stderr, err)
-		os.Exit(1)
-	}
+	config.UpdateBaseConfigWithContext(configDir, contextName)
 	fmt.Printf("Context switched to %s\n", contextName)
 
 	return nil

cmd/config/contexts.go

@@ -135,11 +135,7 @@ func contextsListF(command *cobra.Command, args []string) error {
 		fmt.Fprintln(os.Stderr, err)
 		os.Exit(1)
 	}
-	baseConfig, err := config.LoadBaseConfiguration(config.GetConfigDir())
-	if err != nil {
-		fmt.Fprintln(os.Stderr, err)
-		os.Exit(1)
-	}
+	baseConfig := config.GetBaseConfig(configDir)
 
 	w := tabwriter.NewWriter(os.Stdout, 0, 0, 4, ' ', tabwriter.DiscardEmptyColumns)
 	// header

cmd/config/current.go

@@ -56,23 +56,13 @@ func init() {
 }
 
 func currentContextF(command *cobra.Command, args []string) error {
-	baseConfig, err := config.LoadBaseConfiguration(config.GetConfigDir())
-	if err != nil {
-		fmt.Fprintln(os.Stderr, err)
-		os.Exit(1)
-	}
-
+	baseConfig := config.GetBaseConfig(config.GetConfigDir())
 	fmt.Println(baseConfig.CurrentContext)
 	return nil
 }
 
 func currentClusterF(command *cobra.Command, args []string) error {
-	baseConfig, err := config.LoadBaseConfiguration(config.GetConfigDir())
-	if err != nil {
-		fmt.Fprintln(os.Stderr, err)
-		os.Exit(1)
-	}
-
+	baseConfig := config.GetBaseConfig(config.GetConfigDir())
 	currentContext, err := config.LoadContextConfiguration(config.GetConfigDir(), baseConfig.CurrentContext)
 	if err != nil {
 		fmt.Fprintln(os.Stderr, err)
@@ -94,16 +84,6 @@ func setCurrentContextF(command *cobra.Command, args []string) error {
 }
 
 func updateCurrentContext(newCurrentContext string) error {
-	configDir := config.GetConfigDir()
-	baseConfig, err := config.LoadBaseConfiguration(configDir)
-	if err != nil {
-		return err
-	}
-	if _, err := config.LoadContextConfiguration(configDir, newCurrentContext); err != nil {
-		return err
-	}
-
-	baseConfig.CurrentContext = newCurrentContext
-
-	return config.SaveBaseConfiguration(configDir, baseConfig)
+	config.UpdateBaseConfigWithContext(config.GetConfigDir(), newCurrentContext)
+	return nil
 }

cmd/housekeeping/realms.go

@@ -386,20 +386,7 @@ func realmsCreateF(command *cobra.Command, args []string) error {
 		fmt.Printf("Context %s created successfully\n", contextName)
 
 		// Now set the current context to the new one
-		baseConfig, err := config.LoadBaseConfiguration(configDir)
-		if err != nil {
-			// Shoot out a warning, but don't fail
-			baseConfig = config.BaseConfigFile{}
-			fmt.Fprintf(os.Stderr, "warn: Could not load configuration file: %s. Will proceed creating a new one\n", err.Error())
-		}
-
-		baseConfig.CurrentContext = contextName
-		if err := config.SaveBaseConfiguration(configDir, baseConfig); err != nil {
-			fmt.Fprintln(os.Stderr, err)
-			fmt.Fprintln(os.Stderr, "warn: Context not switched")
-		} else {
-			fmt.Printf("Context switched to %s\n", contextName)
-		}
+		config.UpdateBaseConfigWithContext(configDir, contextName)
 	}
 
 	return nil

config/base.go

@@ -15,10 +15,9 @@
 package config
 
 import (
+	"gopkg.in/yaml.v2"
 	"os"
 	"path"
-
-	"gopkg.in/yaml.v2"
 )
 
 const baseConfigName = "astartectl"
@@ -58,5 +57,6 @@ func SaveBaseConfiguration(configDir string, configuration BaseConfigFile) error
 	if err != nil {
 		return err
 	}
+
 	return os.WriteFile(path.Join(configDir, baseConfigName+".yaml"), contents, 0644)
 }

config/utils.go

@@ -16,6 +16,7 @@ package config
 
 import (
 	"errors"
+	"fmt"
 	"os"
 	"path"
 	"strings"
@@ -43,7 +44,13 @@ func ConfigureViper(contextOverride string) error {
 	}
 
 	// Now, get the current context
-	currentContext := viper.Get("context").(string)
+	currentContextInterface := viper.Get("context")
+	currentContext := ""
+	//in case of empty file, the following check used to fail, now it defaults to empty context and enable file rewrite
+	if currentContextInterface != nil {
+		currentContext = currentContextInterface.(string)
+	}
+
 	// Check overrides
 	if contextOverride != "" {
 		currentContext = contextOverride
@@ -118,7 +125,16 @@ func contextsDirFromConfigDir(configDir string) string {
 
 func listYamlNames(dirName string) ([]string, error) {
 	file, err := os.Open(dirName)
-	if err != nil {
+
+	if os.IsNotExist(err) {
+		//if we cannot open the directory, create it and open again
+		_ = os.MkdirAll(dirName, 0600)
+		file, err = os.Open(dirName)
+		if err != nil {
+			return nil, err
+		}
+
+	} else if err != nil {
 		return nil, err
 	}
 	defer file.Close()
@@ -178,3 +194,38 @@ func ensureConfigDirectoryStructure(configDir string) error {
 	}
 	return nil
 }
+
+func GetBaseConfig(configDir string) BaseConfigFile {
+
+	baseConfig, err := LoadBaseConfiguration(configDir)
+	if err != nil {
+		// Shoot out a warning, but don't fail
+		baseConfig = BaseConfigFile{}
+		fmt.Fprintf(os.Stderr, "warn: Could not load configuration file: %s. Will proceed creating a new one\n", err.Error())
+		// Now set the current context to the new one
+		baseConfig.CurrentContext = ""
+
+		if err := SaveBaseConfiguration(configDir, baseConfig); err != nil {
+			fmt.Fprintln(os.Stderr, err)
+			os.Exit(1)
+		}
+	}
+	return baseConfig
+}
+func UpdateBaseConfigWithContext(configDir, context string) BaseConfigFile {
+	baseConfig, err := LoadBaseConfiguration(configDir)
+	if err != nil {
+		// Shoot out a warning, but don't fail
+		baseConfig = BaseConfigFile{}
+		fmt.Fprintf(os.Stderr, "warn: Could not load configuration file: %s. Will proceed creating a new one\n", err.Error())
+		// Now set the current context to the new one
+	}
+
+	baseConfig.CurrentContext = context
+
+	if err := SaveBaseConfiguration(configDir, baseConfig); err != nil {
+		fmt.Fprintln(os.Stderr, err)
+		os.Exit(1)
+	}
+	return baseConfig
+}